Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Settings not read from [isort] section in setup.cfg #13

Closed
tiktuk opened this issue Oct 17, 2018 · 5 comments
Closed

Settings not read from [isort] section in setup.cfg #13

tiktuk opened this issue Oct 17, 2018 · 5 comments

Comments

@tiktuk
Copy link

tiktuk commented Oct 17, 2018

Could be really nice if config was read from [isort] section so pytest-isort read the same settings as isorton the command line.

@tiktuk
Copy link
Author

tiktuk commented Oct 17, 2018

Oh, it's because it's looking for setup.cfg next to the test file which in my case is in a subfolder. I wonder if it could be made to look for setup.cfg from where pytestwas run.

@stephrdev
Copy link
Owner

Interesting bit. Personally, I use editorconfig to configure isort. Does this problem still exist? If yes, we should try to fix that.

@cb109
Copy link

cb109 commented Aug 12, 2019

I can confirm the isort.cfg from project root is ignored. I could workaround by adding a section to my tox.ini which is parsed as expected.

@stephrdev
Copy link
Owner

I double checked the docs, the config should be named ".isort.cfg" (leading dot) - does it work then?

@cb109
Copy link

cb109 commented Aug 13, 2019

@stephrdev Thank you for taking the time to look into that. You are correct, my bad, .isort.cfg is read as expected 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants