Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Scroll to the selected line #2

Merged
merged 1 commit into from Jun 5, 2019
Merged

Scroll to the selected line #2

merged 1 commit into from Jun 5, 2019

Conversation

lqez
Copy link

@lqez lqez commented Feb 16, 2019

As you see on https://mochajs.org/api/mocha.js.html#line119, line numbers do not exist until linenumber.js is fully initiated, so hash label is not working as intended.

Calling scrollIntoView() can fix this problem.

@jsf-clabot
Copy link

jsf-clabot commented Feb 16, 2019 •
edited

CLA assistant check
All committers have signed the CLA.

@lqez lqez mentioned this pull request Feb 16, 2019
Closed
@boneskull
Copy link
Member

ty!

@boneskull boneskull merged commit 10fae7c into mochajs:master Jun 5, 2019
@lqez lqez deleted the fix-scroll-to-line branch June 7, 2019 09:27
@lqez lqez mentioned this pull request Jun 7, 2019
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@outsideris outsideris outsideris approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@lqez @jsf-clabot @boneskull @outsideris