Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Crash on text styling #179

Open
EdisonJwa opened this issue Nov 14, 2022 · 9 comments
Open

Crash on text styling #179

EdisonJwa opened this issue Nov 14, 2022 · 9 comments
Assignees
Labels
bug Something isn't working crash OS: macos Related to macOS

Comments

@EdisonJwa
Copy link

I was trying to switch the folders and seems the moc is also fetching the data at this time. and then it crashed

version 0.3.0 (15)

The Problem report is as the following

Github reports body is too long and I'll put it in the following gist

https://gist.github.com/EdisonJwa/803c22aa179e978e668b29ee681fefb0

@ggoraa
Copy link
Collaborator

ggoraa commented Nov 14, 2022

Well that looks interesting, it died on text styling, which should not die no matter what
I saw a crash like this in AppCenter Crashes some time ago(smth like months) but was not able to reproduce it

@EdisonJwa
Copy link
Author

Well that looks interesting, it died on text styling, which should not die no matter what I saw a crash like this in AppCenter Crashes some time ago(smth like months) but was not able to reproduce it

if so I'm considering the CJK(Chinese,Japanese, Korean) characters

@EdisonJwa EdisonJwa changed the title Crash on switching folders(or the tabs) or maybe fetch data? Crash on text styling Nov 14, 2022
@ggoraa
Copy link
Collaborator

ggoraa commented Nov 14, 2022

The styling system should support UTF-8 fully, but thanks for clarifying!

@EdisonJwa
Copy link
Author

EdisonJwa commented Nov 14, 2022

The styling system should support UTF-8 fully, but thanks for clarifying!

Seems that the Korean characters will cause the problems
While I'm opening my channel (which contains Korean characters) it crashed
With the following problem report
https://gist.github.com/EdisonJwa/6c64dea09ca85bfc970158418f98af83 (too large to embed)

and the channel for reproducing it
https://t.me/+lcH67pJEr3IzNWY5 (for reproducing the crash)

@EdisonJwa
Copy link
Author

And I'm not sure if the lag was also caused by CJK characters

@ggoraa
Copy link
Collaborator

ggoraa commented Nov 14, 2022

@EdisonJwa what did you do exactly to trigger that crash? i can succesfully open that channel, and Moc doesn't die

@ggoraa
Copy link
Collaborator

ggoraa commented Nov 14, 2022

@EdisonJwa No, lag is definitely not caused by CJK characters, it's a app-wide issue, because of poor optimization

@EdisonJwa
Copy link
Author

EdisonJwa commented Nov 14, 2022

@EdisonJwa what did you do exactly to trigger that crash? i can succesfully open that channel, and Moc doesn't die

Please check the video

Screen.Recording.2022-11-15.at.1.56.51.mov

(Reuploaded)

the report with it
https://gist.github.com/EdisonJwa/3b92e7a632256e570b3c1f74ccf8d71a

@ggoraa
Copy link
Collaborator

ggoraa commented Nov 15, 2022

Hm
You are on macOS Monterey, I am on Ventura, that's probably the reason why I can't reproduce it

@ggoraa ggoraa self-assigned this Nov 17, 2022
@ggoraa ggoraa added bug Something isn't working crash OS: macos Related to macOS labels Nov 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working crash OS: macos Related to macOS
Projects
None yet
Development

No branches or pull requests

2 participants