Upgrading to HHVM 3.25 causes errors due to return type #909
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xxtanisxx
force-pushed
the
fix-return-type-errors-from-hhvm
branch
3 times, most recently
from
f21ecac
to
14c1998
Compare
|
This looks ok to me for now, please could you add a quick test? Just some sort of smoke test, nothing complicated. |
xxtanisxx
changed the title
xxtanisxx
force-pushed
the
fix-return-type-errors-from-hhvm
branch
3 times, most recently
from
242c151
to
8875334
Compare
xxtanisxx
force-pushed
the
fix-return-type-errors-from-hhvm
branch
2 times, most recently
from
4992832
to
5b9644e
Compare
xxtanisxx
force-pushed
the
fix-return-type-errors-from-hhvm
branch
from
5b9644e
to
12b06e6
Compare
xxtanisxx
force-pushed
the
fix-return-type-errors-from-hhvm
branch
from
c4b601b
to
1a4af9c
Compare
xxtanisxx
changed the title
|
Sorry, first time doing this. Not too sure what's the best approach for the test. Hope this will suffice. The newly added test passed the hhvm smoke test. Thanks! |
|
Looks great to me, thank you 👍 |
This was referenced Mar 15, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Return type cannot be properly evaluated by PHP
eval()function. Stripping out the following return type:tuple,array<*>or anything with<*>in it,HH\void,HH\this,HH\ImmVector,HH\ImmMap,HH\ImmSet.The hope is HHVM have a replacement for
eval. If not, this seems to be the best course forward