Add support for PHPUnit 8.0 #942
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LeSuisse
commented
Feb 4, 2019
| @@ -22,19 +22,37 @@ | |||
|
|
|||
| use Mockery; | |||
|
|
|||
| if (\PHP_VERSION_ID < 70000) { | |||
There was a problem hiding this comment.
This might break existing PHPUnit 6 and 7 tests, PHPUnit 8+ should be explicitly targeted instead.
| @@ -20,7 +20,44 @@ | |||
|
|
|||
| namespace Mockery\Adapter\Phpunit; | |||
|
|
|||
| if (\PHP_VERSION_ID < 70000) { | |||
There was a problem hiding this comment.
This might break existing PHPUnit 6 and 7 tests, PHPUnit 8+ should be explicitly targeted instead.
LeSuisse
force-pushed
the
phpunit-8
branch
3 times, most recently
from
86fe6a2
to
be0339e
Compare
|
I have updated the PR to get rid of the PHPUnit 8 deprecation warnings, CI looks happy now. |
|
Thank you, appreciate the effort here. |
|
@davedevelopment Hi, any chance to have release soon? Thanks |
|
Cool, thanks for update 👍 |
|
@davedevelopment appreciated 👌 |
This was referenced Mar 15, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I did not deal with deprecation notices related to the usage of the
@expectedExceptionannotation. If you feel it should be done here, I can update the PR.