PHP 5.6 BC breaking changes in release 1.2.1

[MKodde]

Hi! I'm having some difficulties in using the new mockery version in my PHP 5.6 project.

The first thing that seemed to have been introduced in 1.2.1 is the introduction of a strict_type declaration in the MockeryPHPUnitIntegrationAssertPostConditionsForV7AndPrevious trait. Introduced in this commit.

In my opinion, the solution would be to remove the strict type declaration, or to update the PHP version restraints, but that would result in the release of a new major version I suppose?

The second is an interesting one, and is related to the TestListenerTrait. My version of PHPUnit (5.7.27) provides some forwards compatibility features. These interfere with the condition mentioned in the TestListenerTrait. For, the second portion of the class alias condition does not resolve to be true as the forward compatibility provided by PHPUnit already made the alias for us.

My solution would be to change the second portion of the condition to test for the class existence of PHPUnit\Util\Blacklist

I will open a PR shortly with the proposed changes. Please feel free to steer me in a more desired direction.

[BackEndTea]

In my opinion, the solution would be to remove the strict type declaration, or to update the PHP version restraints, but that would result in the release of a new major version I suppose?

Depending on how you interpet semver, bumping the php version does not constitue a bump in major version of a package. Because composer will halt installation of that new version, because it is incompatible with your php version.

It would be bad practice to do this in a patch version, or not communicate this properly though.

[davedevelopment]

Fixed in #947, thank you

[MKodde]

Thanks for the quick response and reviewing guys, I'm closing this issue!