Added an argument expectation method to check if expected arguments are parts of real arguments when mocked methods are called #967
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…re parts of real arguments when mocked methods are called
robertbasic
reviewed
Apr 28, 2019
There was a problem hiding this comment.
Thanks @yutod for this feature! Would you mind adding it to the docs as well with this PR?
Added a doc for argument expectation method 'withSomeOfArgs'
|
@robertbasic Thanks for reviewing and feedback! |
robertbasic
approved these changes
Apr 30, 2019
|
Looking good, thanks @yutod! |
|
@davedevelopment If you have further suggestion or any feedback, I'll happily improve it! Thank you, |
This was referenced Mar 15, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is a wrapper of argument expectation.
Already custom validation for arguments can be possible to pass callback function to
withArgs, which is good!However, I'd like to suggest the feature to reduce our test code to prepare this wrapper method.
This method helps you to check if expected arguments are actually set when mocked methods are called.