verifyNoMoreInteractions inconsistent behavior

[blueacorn]

The verifyNoMoreInteractions method has an expectation that if will flag unexpected (unchecked) interactions on the related mocks. For Example:

verifyNoMoreInteractions(mocks)

• will correctly flag any unexpected (unchecked) interactions

However, when it is used with an inOrder context, the code does not behave as expected:

  InOrder inOrder = inOrder(mock, mock2, ...);
  inOrder.verify(mock).firstCheck();
  ... 
  inOrder.verify(mock).lastCheck();
  inOrder.verifyNoMoreInteractions() ;
}

• correctly flags any unexpected (unchecked) interactions after lastCheck
• incorrectly ignores any unexpected (unchecked) interactions before lastCheck

Example

The following example illustrates how the placement of verifyNoMoreInteractions changes the behavior. (note the example is written in kotlin, but the affected library is mockito-core)

import org.junit.jupiter.api.Test
import org.junit.jupiter.api.extension.ExtendWith
import org.mockito.Mock
import org.mockito.junit.jupiter.MockitoExtension

@ExtendWith(MockitoExtension::class)
class ExampleTest {

  @Mock var lateinit instanceA: ClassA
  @Mock var lateinit instanceB: ClassB
  @Mock var lateinit instanceC: ClassC

  val allMocks = Lazy { arrayOf(instanceA, instanceB, instanceC) }

  @Test
  fun example() {
       // WHEN
       instanceA.methodCallA()
       instanceB.methodCallB()
       instanceC.methodCallC()

        // THEN
        inOrder(*allMocks.value) {

             verify(instanceC).methodCallC()

            verifyNoMoreInteractions()            // <-- Does **not** flag unchecked A,B interactions (incorrect)
        }
        verifyNoMoreInteractions(*allMocks.value) // <-- Correctly flags any unchecked interactions
  }
}

Suggestions

Perhaps the [re-use of] method name causes some confusion in expectation:

• verifyNoMoreInteractions vs. verifyNoOtherInteractions vs. inOrder.verifyLastInteraction vs. inOrder.verifyNoOtherInteractions

Checklist

• The mockito message in the stacktrace have useful information, but it didn't help
• The problematic code (if that's possible) is copied here;
  Note that some configuration are impossible to mock via Mockito
• Provide versions (mockito / jdk / os / any other relevant information)
• Mockito-2.22
• JUnit5 5.x
• Mockito-kotlin = 2.x
• JDK 1.8
• Provide a Short, Self Contained, Correct (Compilable), Example of the issue
  (same as any question on stackoverflow.com)
• Read the contributing guide

[mockitoguy]

inOrder.verifyNoMoreInteractions() is different than Mockito.verifyNoMoreInteractions(). Take a look at the Javadoc. If the Javadoc is not clear, please submit a PR ;-)