Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve examples for InOrder #2843

Merged
merged 2 commits into from Jan 15, 2023
Merged

Improve examples for InOrder #2843

merged 2 commits into from Jan 15, 2023

Conversation

ascopes
Copy link
Contributor

@ascopes ascopes commented Dec 30, 2022

Include some context in InOrder examples and add an example that uses a static mock as well.

I spent a while being unable to work out how to integrate InOrder with static mocks before realising the example of how to do this is currently encoded in a specific overload of a specific method within InOrder that I had missed as I was not using it.

Checklist

  • Read the contributing guide
  • PR should be motivated, i.e. what does it fix, why, and if relevant how
  • If possible / relevant include an example in the description, that could help all readers
    including project members to get a better picture of the change
  • Avoid other runtime dependencies
  • Meaningful commit history ; intention is important please rebase your commit history so that each
    commit is meaningful and help the people that will explore a change in 2 years
  • The pull request follows coding style

Include some context in InOrder examples and add an example that uses
a static mock as well.
@ascopes
Copy link
Contributor Author

ascopes commented Jan 2, 2023

Fixed JavaDoc error encountered when building under JDK11

@codecov-commenter
Copy link

codecov-commenter commented Jan 15, 2023

Codecov Report

Base: 84.88% // Head: 84.76% // Decreases project coverage by -0.12% ⚠️

Coverage data is based on head (0bfb55b) compared to base (ffb294c).
Patch has no changes to coverable lines.

Additional details and impacted files
@@             Coverage Diff              @@
##               main    #2843      +/-   ##
============================================
- Coverage     84.88%   84.76%   -0.13%     
+ Complexity     2875     2867       -8     
============================================
  Files           327      327              
  Lines          8761     8780      +19     
  Branches       1060     1068       +8     
============================================
+ Hits           7437     7442       +5     
- Misses         1047     1064      +17     
+ Partials        277      274       -3     
Impacted Files Coverage Δ
src/main/java/org/mockito/InOrder.java 100.00% <ø> (ø)
src/main/java/org/mockito/plugins/MockMaker.java 0.00% <0.00%> (-87.50%) ⬇️
...creation/instance/DefaultInstantiatorProvider.java 50.00% <0.00%> (-50.00%) ⬇️
...a/org/mockito/internal/debugging/LocationImpl.java 0.00% <0.00%> (-35.09%) ⬇️
...creation/bytebuddy/SubclassByteBuddyMockMaker.java 47.29% <0.00%> (-24.33%) ⬇️
.../mockito/internal/util/reflection/FieldReader.java 77.77% <0.00%> (-22.23%) ⬇️
...nternal/creation/bytebuddy/ByteBuddyMockMaker.java 61.90% <0.00%> (-19.05%) ⬇️
...rnal/util/reflection/ReflectionMemberAccessor.java 61.11% <0.00%> (-8.34%) ⬇️
.../main/java/org/mockito/internal/util/Platform.java 76.92% <0.00%> (-7.70%) ⬇️
...rnal/creation/bytebuddy/MockMethodInterceptor.java 77.77% <0.00%> (-7.41%) ⬇️
... and 13 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@TimvdLippe TimvdLippe merged commit f2a47c3 into mockito:main Jan 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants