Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] Invalid email can be passed as argument for MAIL FROM, RCPT TO commands #135

Open
4 tasks done
bestwebua opened this issue Nov 18, 2022 · 0 comments
Open
4 tasks done
Assignees
Labels
bug Something isn't working

Comments

@bestwebua
Copy link
Member

bestwebua commented Nov 18, 2022

New bug checklist

Bug description

Regex for validation of email works in wrong way. We can pass to MAIL FROM, RCPT TO invalid email, like a@a.com@b.com. Seems when wrong email ends on valid domain it passes (a@a.com@b.com). We need to fix it and cover via tests.

Complete output when running smtpmock, including the stack trace and command used
INFO: 2022/11/18 19:20:12.419178 SMTP session started
INFO: 2022/11/18 19:20:12.419265 SMTP response: 220 Welcome
INFO: 2022/11/18 19:20:12.419533 SMTP request: EHLO gibson.biz
INFO: 2022/11/18 19:20:12.421156 SMTP response: 250 Received
INFO: 2022/11/18 19:20:12.421370 SMTP request: MAIL FROM:<evonne.langosh@hammes.ca>
INFO: 2022/11/18 19:20:12.421935 SMTP response: 250 Received
INFO: 2022/11/18 19:20:12.422099 SMTP request: RCPT TO:<a@a.com@b.com>
INFO: 2022/11/18 19:20:12.422823 SMTP response: 250 Received
INFO: 2022/11/18 19:20:12.422972 SMTP request: DATA
@bestwebua bestwebua added the bug Something isn't working label Nov 18, 2022
@bestwebua bestwebua self-assigned this Nov 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Development

No branches or pull requests

1 participant