Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds manual install script like babashka #61

Merged
merged 2 commits into from Sep 25, 2022
Merged

Adds manual install script like babashka #61

merged 2 commits into from Sep 25, 2022

Conversation

rafaeldelboni
Copy link
Collaborator

I don´t know if you folks are open for PRs, but I just used your tool, which is super easy to use.

But I missed an easier way to install it on my dev machine, this PR aims to solve this for Linux and Mac users.

Regards.

@rafaeldelboni rafaeldelboni temporarily deployed to release September 25, 2022 13:08 Inactive
Copy link
Member

@avelino avelino left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@avelino avelino merged commit 042dad8 into moclojer:main Sep 25, 2022
@avelino
Copy link
Member

avelino commented Sep 25, 2022

@rafaeldelboni thanks for helping to simplify the installation of moclojer, our mission is to be as familiar as possible for our users who don't know clojure (especially for those who just want to use moclojer and not contribute)

@rafaeldelboni
Copy link
Collaborator Author

rafaeldelboni commented Sep 25, 2022

Following your mission, maybe add 3 arguments to the main function would be nice:
--help/-h, --config/-c and --mock/-m
This would make moclojer even more like a cli tool, wdyt?

There are some tools to help this like docopt.clj

Another thing I would do, is to search for a default config in the home dir of the user, like ~/.config/moclojer/config

I can open a issue if this interest you, and maybe implement :)

@avelino
Copy link
Member

avelino commented Sep 26, 2022

I agree with both points, to keep the project organized (here on github) you can open two issues proposing these improvements?

@rafaeldelboni
Copy link
Collaborator Author

#62
#63

@avelino avelino added this to the 0.2 milestone Apr 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants