Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

JackTickDouble undeclared #55

Closed
quochuy opened this issue May 31, 2022 · 6 comments
Closed

JackTickDouble undeclared #55

quochuy opened this issue May 31, 2022 · 6 comments

Comments

@quochuy
Copy link

quochuy commented May 31, 2022

When running make on Ubuntu 18 or 20 it fails with that error.
What's the previous version that works on those distros?

@falkTX
Copy link
Member

falkTX commented May 31, 2022

the error is intentional, old versions of jack do not have a few things which make mod-host have bad timing.

@falkTX falkTX closed this as completed May 31, 2022
@ajboni
Copy link

ajboni commented Sep 25, 2022

Hi, im getting the same with pipewire-jack on arch linux. Does that means that it is outdated vs jack2?

EDIT: As a test, went back to jack2, compiled and back to pipewire-jack seems to be working alright so far

@falkTX
Copy link
Member

falkTX commented Sep 25, 2022

pipewire likely has old jack2 based headers, before these additions were added.
fill a bug report with them.

FYI both latest jack1 and jack2 provide these definitions since quite some time now.

@Lotharyx
Copy link

Lotharyx commented Dec 31, 2022

It looks like you need to update your README.md to call out libjack-jackd2-dev version 1.9.19 or later, as that is the version that introduced JackTickDouble. See https://jackaudio.org/news/2021/07/16/jack2-v1919-release.html

@danielappelt
Copy link

I have just opened a ticket in pipewire.

@wtay
Copy link

wtay commented Apr 28, 2023

It should only use the field and flags when JACK_TICK_DOUBLE is defined.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants