Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Abandonned and unmaintened pycrypto -> use pycryptodome instead. #128

Closed
jujudusud opened this issue Jun 30, 2022 · 3 comments
Closed

Abandonned and unmaintened pycrypto -> use pycryptodome instead. #128

jujudusud opened this issue Jun 30, 2022 · 3 comments

Comments

@jujudusud
Copy link

Hi here,

Since pycrypto is unmaintened and forked to pycryptodome, We should use it as a requirement to build mod-ui.

Please take a look at: pycryptodome.

Do you want me to provide a PR?
We only have to change requirement.txt file with the new pycryptodome.
@falkTX
Copy link
Member

falkTX commented Jun 30, 2022

PyCryptodome does not support python3.4, which is a blocker for MOD use.

@jujudusud
Copy link
Author

jujudusud commented Jul 1, 2022 •
edited

AFAIK, PyCryptodome 3.9.9 (Nov 2, 2020) does support Python 3.4.
I don't know if this is sufficient to be use in MOD.

Did define version-constrained / conditional requirements a solution ?

@falkTX
Copy link
Member

falkTX commented Nov 28, 2023

This is fixed by fc843bd

@falkTX falkTX closed this as completed Nov 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@falkTX @jujudusud