Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Handle VarDebugInfoContents::Composite in GotocCtx::find_debug_info #1933

Open
zhassan-aws opened this issue Nov 23, 2022 · 0 comments
Open

Handle VarDebugInfoContents::Composite in GotocCtx::find_debug_info #1933

zhassan-aws opened this issue Nov 23, 2022 · 0 comments
Labels
[C] Internal Tracks some internal work. I.e.: Users should not be affected.

Comments

@zhassan-aws
Copy link
Contributor

The Composite variant of the VarDebugInfoContents enum was added in rust-lang/rust#102570, and is concerned with the scalar replacement of aggregates (SROA) MIR optimization that is only enabled with --mir-opt-level=3 or higher.

In #1927, we handled this new variant by considering it to not match the debug info for any Local, which would result in the callers (codegen_var_base_name and codegen_var_name) producing a name that excludes the variable name from the debug info. We need to figure out if this is OK to do, e.g. by experimenting with one of the unit tests in rust-lang/rust#102570.
@zhassan-aws zhassan-aws added the [C] Internal Tracks some internal work. I.e.: Users should not be affected. label Nov 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
[C] Internal Tracks some internal work. I.e.: Users should not be affected.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@zhassan-aws