Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extent vs. line thickness #1896

Closed
modelica-trac-importer opened this issue Nov 4, 2018 · 7 comments
Closed

Extent vs. line thickness #1896

modelica-trac-importer opened this issue Nov 4, 2018 · 7 comments
Assignees
Labels
bug Something isn't working

Comments

@modelica-trac-importer
Copy link
Collaborator

Reported by stefanv on 26 Jan 2016 20:15 UTC
When a rectangle annotation specifies, for example, extent = {{-20,-20},{20,20}}, and a non-zero line thickness, does all of the rectangle's rendered border fit within the extent, or does the extent describe the theoretical zero-thickness border, and the actual rendered border is then half inside and half outside the extent?

This is not mentioned in the specification.


Migrated-From: https://trac.modelica.org/Modelica/ticket/1896

@modelica-trac-importer
Copy link
Collaborator Author

Comment by hansolsson on 29 Jan 2016 15:28 UTC
Replying to [ticket:1896 stefanv]:

When a rectangle annotation specifies, for example, extent = {{-20,-20},{20,20}}, and a non-zero line thickness, does all of the rectangle's rendered border fit within the extent, or does the extent describe the theoretical zero-thickness border, and the actual rendered border is then half inside and half outside the extent?

This is not mentioned in the specification.

I would go for the theoretical zero-thickness border, especially for polygons where it otherwise would be needlessly complicated. And having different logic for Rectangle and Polygon would be odd.

And in the list of possibilities we can also include the border outside the extent.

@modelica-trac-importer
Copy link
Collaborator Author

Comment by dag on 29 Jan 2016 15:50 UTC
The behavior in one common toolkit is described here: http://doc.qt.io/qt-5/coordsys.html#aliased-painting.

@modelica-trac-importer
Copy link
Collaborator Author

Modified by stefanv on 3 Mar 2016 16:48 UTC

@modelica-trac-importer
Copy link
Collaborator Author

Comment by hansolsson on 7 Mar 2016 17:40 UTC
Modelica design meeting:
Extent describe the theoretical zero-thickness border, and the actual rendered border is then half inside and half outside the extent.

@modelica-trac-importer
Copy link
Collaborator Author

Comment by hansolsson on 7 Mar 2016 17:47 UTC
Modelica design meeting:
Separate point: does the border pattern go inside or outside the extent?
For sunk, raised: decoration outside the button - or inside extent?

Conclusion - inside extent; assuming this is the current implementation.

@modelica-trac-importer
Copy link
Collaborator Author

Comment by hansolsson on 23 Mar 2016 15:08 UTC
Resolved in r9232

@modelica-trac-importer
Copy link
Collaborator Author

Modified by hansolsson on 23 Mar 2016 15:51 UTC

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests