Dymola-specific code in MSL 3.2.1

[modelica-trac-importer]

Reported by fcasella on 11 Mar 2013 11:41 UTC
A search for "Dymola" in the trunk reveals that there are still two Dymola-specific classes left in Modelica, inside Modelica.Media.Incompressible. In both cases the code reads:

// Dummy definition has to be added for current Dymola
   redeclare function extends solve
   end solve;

This code should obviously have no effect, and it was added to the libary back in February 2006, when the "current" version of Dymola was 6.0 or something like that. I guess it should be removed.

---

Migrated-From: https://trac.modelica.org/Modelica/ticket/1014

[modelica-trac-importer]

Comment by hansolsson on 11 Mar 2013 15:10 UTC
I will have to check this in more detail. But I would propose to keep the dummy function for this release at least - it seems pretty harmless from the user perspective.

You could possibly replace 'Dymola' by 'some tools' if someone does not like 'Dymola' here.

[modelica-trac-importer]

Comment by otter on 26 Mar 2013 16:29 UTC
Changed the comment to "dummy definition (has to be added for one tool)" in e719077. Since this is correct Modelica code, this is still fine and it is not worth to keep this ticket.

[modelica-trac-importer]

Comment by dietmarw on 26 Mar 2013 19:02 UTC
I don't agree that keeping dummy code for what ever reason. The MSL is often regarded as the standard implementation and when users look at the code they should not be guided to "this is how you should code Modelica". Also the "one tool" can without problem patch the MSL for their delivery just like all the other tools had to do because of some "one tool special code".

So rather than closing this as "fixed" (which it isn't) it should be left open and rescheduled (the current workaround might be acceptable for the upcoming release) and then removed it for the next one just like Hans suggested.

[modelica-trac-importer]

Modified by otter on 18 Jul 2013 12:01 UTC

[modelica-trac-importer]

Comment by hansolsson on 18 Jun 2015 10:01 UTC
I thought I yesterday added that it no longer seems needed in current Dymola versions.
Unfortunately I cannot change it to "default" owner.

[modelica-trac-importer]

Modified by dietmarw on 18 Jun 2015 11:20 UTC

[modelica-trac-importer]

Comment by hubertus on 18 Jun 2015 21:06 UTC
Fixed in 928961c for trunk and in e8805db for the 3.2.1 maintenance branch

[modelica-trac-importer]

Modified by hubertus on 18 Jun 2015 21:13 UTC

[modelica-trac-importer]

Modified by dietmarw on 19 Jun 2015 06:01 UTC

[modelica-trac-importer]

Changelog modified by dietmarw on 19 Jun 2015 06:01 UTC
Tool-specific workaround removed.