Fix usage of GenerateEvents and Inline annotations in Modelica.Fluid

[modelica-trac-importer]

Reported by fcasella on 12 Mar 2013 14:28 UTC
All GenerateEvents = false instances in Modelica.Fluid can be safely removed (because that is the default option, and the annotation might just be confusing).

The GenerateEvents annotation in Modelica.Media.IdealGases.Common.Functions.s0_T(), s0_Tlow(),and s0Tlow_der could be removed (the functions are smooth enough)

Based on the new definition of the GenerateEvents in Modelica 3.2 rev2, all setState_XX() functions in Modelica.Media.Water.WaterIF97_base should have the annotation GenerateEvents = true, as well as all the chain of functions from setState_XX() down to the functions that contain the conditional expressions in the algorithm.

---

Migrated-From: https://trac.modelica.org/Modelica/ticket/1017

[modelica-trac-importer]

Comment by fcasella on 12 Mar 2013 15:02 UTC
setState_XX functions in WaterIF97_base and in WaterIF97_fixedregion handle the phase input differently. The reason of that should be made clear, and annotations set up accordingly in the whole function call chain.

[modelica-trac-importer]

Comment by fcasella on 12 Mar 2013 15:04 UTC
setState_XX functions in WaterIF97_base and WaterIF97_fixedregion do not have the Inline = true annotation. Shouldn't they have it?

[modelica-trac-importer]

Comment by fcasella on 13 Mar 2013 09:32 UTC
Hubertus advises to add the Inline = true annotation to all one-liner functions in Media that don't have any Inline or LateInline annotation, as this allows to exploit all equation-based optimization.

This is also important because different tools have different default attitudes towards inlining, so if that can become important for efficiency, it should be explicitly specified.

[modelica-trac-importer]

Comment by fcasella on 13 Mar 2013 22:11 UTC
The last changes in the Modelica Specification 3.2 ver2 regarding GenerateEvents make it only necessary to set the GenerateEvent annotation on three functions in Media (it is no longer necessary to set the annotation through the entire function call chain). All unnecessary or wrong annotations have been removed in cfa31e6.

Inline = true annotations have also been set in cfa31e6, for all function of Modelica.Media that can benefit in terms of reduced overhead.