Use equation-section in M_Transformer

[modelica-trac-importer]

Reported by sjoelund.se on 24 Mar 2013 07:33 UTC
Modelica.Electrical.Analog.Basic.M_Transformer currently has an algorithm-section instead of the following basic equation (which is much easier to invert):

equation
  for s in 1:N loop
     for z in 1:N loop
       Lm[z,s] = if (z>=s) then L[(s-1)*N+z-div((s-1)*s,2)] else Lm[s,z];
     end for;
  end for;

I'd suggest changing it since there to me doesn't seem to be any reason to keep it an algorithm-section.

---

Migrated-From: https://trac.modelica.org/Modelica/ticket/1045

[modelica-trac-importer]

Comment by otter on 26 Mar 2013 16:35 UTC
This could be further improved:
Basically Lm depends only on parameter L. Therefore, it should be treated as parameter that is computed during initialization. I would propose to change the code to:

   parameter Modelica.SIunits.Inductance Lm[N,N](final fixed=false);
initial equation 
  for s in 1:N loop
     for z in 1:N loop
       Lm[z,s] = if (z>=s) then L[(s-1)*N+z-div((s-1)*s,2)] else Lm[s,z];
     end for;
  end for;

[modelica-trac-importer]

Comment by clauss on 27 Mar 2013 08:15 UTC
fixed in 7a56919. Thanks for reporting that.

[modelica-trac-importer]

Modified by clauss on 27 Mar 2013 08:16 UTC

[modelica-trac-importer]

Modified by majetta on 5 Apr 2013 12:57 UTC

[modelica-trac-importer]

Changelog modified by majetta on 5 Apr 2013 12:57 UTC
Model M_Transformer improved

[modelica-trac-importer]

Modified by majetta on 10 Apr 2013 12:55 UTC

[modelica-trac-importer]

Changelog modified by majetta on 10 Apr 2013 12:55 UTC
Variable Lm in model M_Transformer changed into parameter. Functionality of the model moved from algorithm section to equation section.