Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PartialMedium changed in a non-backwards compatible way #1092

Closed
modelica-trac-importer opened this issue Jan 14, 2017 · 5 comments
Closed
Assignees
Labels
bug Critical/severe issue L: Media Issue addresses Modelica.Media P: highest Highest priority issue
Milestone

Comments

@modelica-trac-importer
Copy link

Reported by otter on 12 May 2013 19:17 UTC
The Modelica.Media.Interfaces.PartialMedium package has been changed in a non-backwards compatible way, in order to fix issues using instances of a partial package:

  • The Choices package inside PartialMedium has been moved one level up.
  • All type definitions in PartialMedium have been moved one level up.

As a result, existing media models using these elements will not work with MSL 3.2.1.


Migrated-From: https://trac.modelica.org/Modelica/ticket/1092

@modelica-trac-importer modelica-trac-importer added this to the MSL3.2.1 milestone Jan 14, 2017
@modelica-trac-importer modelica-trac-importer added bug Critical/severe issue L: Media Issue addresses Modelica.Media P: highest Highest priority issue labels Jan 14, 2017
@modelica-trac-importer
Copy link
Author

Comment by otter on 12 May 2013 19:22 UTC
Fixed in 8a096cc:

  • package Choices re-introduced in PartialMedium as a short class definition to Modelica.Media.Interfaces.Choices.

  • all type definitions re-introduced in PartialMedium with short class definitions to Modelica.Media.Interfaces.Types.XXX.

In all cases an "obsolete annotation" added to the definition. New models should use the Modelica.Media.Interfaces.Choices/Types definitions. Existing models will, however, still work.

@modelica-trac-importer
Copy link
Author

Changelog modified by otter on 12 May 2013 19:22 UTC
Modelica.Media.Interfaces.PartialMedium: Choices and Types definition re-introduced as obsolete elements in order that Media are backwards compatible (have been previously moved one level up to Media.Interfaces)

@modelica-trac-importer
Copy link
Author

Comment by otter on 12 May 2013 19:42 UTC
Fixed again in b96f428:

The fix with the types was not good, because package Interfaces.Types was inherited into PartialPackages with extends and then two type definitions have been present. Removed the newly introduced "obsolete" type definitions.

@modelica-trac-importer
Copy link
Author

Changelog modified by otter on 12 May 2013 19:42 UTC
Modelica.Media.Interfaces.PartialMedium: Choices definition re-introduced as obsolete element in order that Media are backwards compatible (has been previously moved one level up to Media.Interfaces.Choices)

@modelica-trac-importer
Copy link
Author

Modified by otter on 20 Dec 2016 15:12 UTC

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Critical/severe issue L: Media Issue addresses Modelica.Media P: highest Highest priority issue
Projects
None yet
Development

No branches or pull requests

2 participants