Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OpenSourceTables: Evaluation of table file name #1178

Closed
modelica-trac-importer opened this issue Jan 14, 2017 · 3 comments
Closed

OpenSourceTables: Evaluation of table file name #1178

modelica-trac-importer opened this issue Jan 14, 2017 · 3 comments
Assignees
Labels
bug Critical/severe issue L: Blocks Issue addresses Modelica.Blocks
Milestone

Comments

@modelica-trac-importer
Copy link

Reported by beutlich on 26 Jun 2013 08:37 UTC
Revision caf6227 set the table file name string parameter to always be evaluated. This, however is not acceptable for some SimulationX users. In the past we had the requirement to run variant calculations of the C-code exported model on the table file name. This feature is now broken. I also believe that caf6227 is not backward compatible with MSL 3.2.


Migrated-From: https://trac.modelica.org/Modelica/ticket/1178

@modelica-trac-importer modelica-trac-importer added this to the MSL3.2.1 milestone Jan 14, 2017
@modelica-trac-importer modelica-trac-importer added bug Critical/severe issue L: Blocks Issue addresses Modelica.Blocks labels Jan 14, 2017
@modelica-trac-importer
Copy link
Author

Comment by beutlich on 26 Jun 2013 13:23 UTC
By the way, there are far more calls to loadResource in the MSL than the four changed ones.

@modelica-trac-importer
Copy link
Author

Comment by otter on 27 Jun 2013 10:33 UTC
Fixed in 0052a94 and 6748be6:

The issue is that loadResource(..) was included at several location in models, in order to conveniently support URIs for file names. However, the drawback is that some tools might need to evaluate loadResource at compile time, and this might not be always be possible in all situations. The fix removes all (generic) loadResource(..) calls from the models and a user has to use it explicitely to construct a file name. By this it is guaranteed that existing models/libraries will work. There are some examples and defaults where loadResource(..) is used and reference files under Modelica/Resources. This occurences are kept since otherwise these files cannot be read in a reliable way and these uses of loadResource are uncritical.

Furthermore, ModelicaTest.Tables was adapted by including explicit loadResource(..) calls.

@modelica-trac-importer
Copy link
Author

Modified by otter on 27 Jun 2013 10:33 UTC

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Critical/severe issue L: Blocks Issue addresses Modelica.Blocks
Projects
None yet
Development

No branches or pull requests

2 participants