Cyclical definition in Modelica.Media.Incompressible.TableBased

[modelica-trac-importer]

Reported by eshmoylova on 10 Jan 2014 17:23 UTC
When package Modelica.Media.Incompressible.TableBased extends Modelica.Media.Interfaces.PartialMedium it modifies the definition of the Temperature type as
Temperature(min = T_min, max = T_max));
T_min and T_max are later defined to be of type Temperature:
constant Temperature T_min "Minimum temperature valid for medium model";
constant Temperature T_max "Maximum temperature valid for medium model";

It creates a cyclical definition of type Temperature in this class. In order to resolve the definition of Temperature we need to determine T_min and T_max, in order to determine T_min and T_max we need to resolve their type Temperature, which we can resolve only when we resolve the type of T_min and T_max.
A simple fix would be to define T_min and T_max to be of type Modelica.SIunits.Temperature.

---

Migrated-From: https://trac.modelica.org/Modelica/ticket/1390

[modelica-trac-importer]

Comment by eshmoylova on 6 Feb 2014 20:30 UTC
What is the resolution on this ticket? Is it a bug in the library that should be fixed?

[modelica-trac-importer]

Comment by hubertus on 6 Feb 2014 20:36 UTC
This is a bug that should be fixed. Your fix will work.

[modelica-trac-importer]

Comment by hubertus on 6 Feb 2014 20:41 UTC
Fixed in 21bf512. Only checks performed no detailed testing, but it is a minimal change.

[modelica-trac-importer]

Comment by dietmarw on 6 Feb 2014 21:59 UTC
The ticket was filed as blocker but without specifying a milestone. Am I right that this should be fixed for MSL 3.2.2? Also when closing tickets, please fill in the Release Notes field with a short summary what was fixed (will appear later in the release notes).

[modelica-trac-importer]

Modified by hubertus on 6 Feb 2014 22:23 UTC

[modelica-trac-importer]

Changelog modified by hubertus on 6 Feb 2014 22:23 UTC
Removed circular type definition for temperature

[modelica-trac-importer]

Modified by hubertus on 6 Feb 2014 22:24 UTC

[modelica-trac-importer]

Changelog modified by hubertus on 6 Feb 2014 22:24 UTC
Removed circular type definition for Temperature type

[modelica-trac-importer]

Comment by dietmarw on 6 Feb 2014 22:29 UTC
Hubertus, you'll need to also fix it in the maintenance branch since trunk is only 3.2.2.

[modelica-trac-importer]

Comment by beutlich on 17 Aug 2015 10:16 UTC
Fixed in b915cac for maintenance branch.