Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove experiment annotation from subcircuits in Modelica.Electrical.Spice3.Examples.Spice3BenchmarkFourBitBinaryAdder #1404

Closed
modelica-trac-importer opened this issue Jan 14, 2017 · 2 comments
Closed

Remove experiment annotation from subcircuits in Modelica.Electrical.Spice3.Examples.Spice3BenchmarkFourBitBinaryAdder #1404

modelica-trac-importer opened this issue Jan 14, 2017 · 2 comments
Assignees
@ECClauss
Labels
enhancement New feature or enhancement L: Electrical.Spice3 Issue addresses Modelica.Electrical.Spice3 P: high High priority issue
Milestone
MSL3.2.1+build.3

Comments

@modelica-trac-importer
Copy link

Reported by leo.gall on 22 Jan 2014 16:29 UTC
Are the following models intended to be simulated by a user?

Modelica.Electrical.Spice3.Examples.Spice3BenchmarkFourBitBinaryAdder.FOURBIT
Modelica.Electrical.Spice3.Examples.Spice3BenchmarkFourBitBinaryAdder.NAND
Modelica.Electrical.Spice3.Examples.Spice3BenchmarkFourBitBinaryAdder.ONEBIT
Modelica.Electrical.Spice3.Examples.Spice3BenchmarkFourBitBinaryAdder.TWOBIT

They are encapsulated in a model, not in a package.
I would prefer to remove the experiment annotation (StopTime, Interval).

Background: for regression testing of MSL, all models with a StopTime annotation should be executed. I think it would be enough to execute Modelica.Electrical.Spice3.Examples.Spice3BenchmarkFourBitBinaryAdder.

Migrated-From: https://trac.modelica.org/Modelica/ticket/1404
@modelica-trac-importer modelica-trac-importer added enhancement New feature or enhancement L: Electrical.Spice3 Issue addresses Modelica.Electrical.Spice3 P: high High priority issue labels Jan 14, 2017
@modelica-trac-importer
Copy link
Author

Comment by majetta on 31 Jan 2014 07:04 UTC
The experiment annotations (StopTime, Interval) in
Modelica.Electrical.Spice3.Examples.Spice3BenchmarkFourBitBinaryAdder.FOURBIT
Modelica.Electrical.Spice3.Examples.Spice3BenchmarkFourBitBinaryAdder.NAND
Modelica.Electrical.Spice3.Examples.Spice3BenchmarkFourBitBinaryAdder.ONEBIT
Modelica.Electrical.Spice3.Examples.Spice3BenchmarkFourBitBinaryAdder.TWOBIT
were removed in b99339c.
Also the documentation of Modelica.Electrical.Spice3.Examples.Spice3BenchmarkFourBitBinaryAdder was improved in b99339c.

@modelica-trac-importer
Copy link
Author

Changelog modified by majetta on 31 Jan 2014 07:04 UTC
The experiment annotations (StopTime, Interval) in Modelica.Electrical.Spice3.Examples.Spice3BenchmarkFourBitBinaryAdder.FOURBIT Modelica.Electrical.Spice3.Examples.Spice3BenchmarkFourBitBinaryAdder.NAND Modelica.Electrical.Spice3.Examples.Spice3BenchmarkFourBitBinaryAdder.ONEBIT Modelica.Electrical.Spice3.Examples.Spice3BenchmarkFourBitBinaryAdder.TWOBIT were removed. Also the documentation of Modelica.Electrical.Spice3.Examples.Spice3BenchmarkFourBitBinaryAdder was improved.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ECClauss ECClauss

Labels
enhancement New feature or enhancement L: Electrical.Spice3 Issue addresses Modelica.Electrical.Spice3 P: high High priority issue
Projects
None yet
Milestone
MSL3.2.1+build.3
Development

No branches or pull requests
2 participants
@modelica-trac-importer @ECClauss