ModelicaStandardTables: Avoid C++ implementation for shared table arrays

[modelica-trac-importer]

Reported by beutlich on 7 Aug 2014 07:28 UTC
In #1110 a C++ implementation supporting common/shared table arrays (i.e. same table from same file referenced by multiple table objects) was committed. Actually C++ was used for two reasons

1. Support of std::map container class
2. Static initialization/finalization of module functions in order to call InitializeCriticalSection/DeleteCriticalSection in case of Win platforms.
   In Get rid of static buffer in ModelicaInternal #1433 we discussed that the C++ layer actually can be avoided.

---

Migrated-From: https://trac.modelica.org/Modelica/ticket/1550

[modelica-trac-importer]

Comment by beutlich on 7 Aug 2014 08:06 UTC
Resolved by 01a172d.

Martin (S.): Can you please define TABLE_SHARE in OMC to test it. I already did compile tests with GCC on Linux (where Posix threads are available) and MinGW (where it falls back to the _WIN32 branch).

ToDo: Should we rename uthash and gconstructor headers to avoid name clashes? At least we should mention them in the license exclusions of MSL.

[modelica-trac-importer]

Comment by sjoelund.se on 7 Aug 2014 09:06 UTC
Fixed in 8784de1. There should be no need to rename the uthash header since local headers take precedence and noone will set their include path to include Modelica/Resources/C-Sources for projects other than this one. And yes, if we list license exclusions, we should list the exceptions there.

(I am unsure why we would need the gconstructor stuff; if it is for FMU's, tools should anyway terminate the simulation which means we can reference count the external objects and free the main hash table. It does no harm as it is though.)

[modelica-trac-importer]

Comment by beutlich on 7 Aug 2014 09:20 UTC
Thanks for the fix.

License info is fixed in 3cd32ed.

The gconstructor stuff is required to have a module-wide initialization call of InitializeCriticalSection and finalization call of DeleteCriticalSection on Win. See also http://stackoverflow.com/questions/1113409/attribute-constructor-equivalent-in-vc.

[modelica-trac-importer]

Modified by beutlich on 7 Aug 2014 09:24 UTC

[modelica-trac-importer]

Changelog modified by beutlich on 7 Aug 2014 09:24 UTC
Rewrote implementation of shared tables of Modelica Standard Tables in pure C

[modelica-trac-importer]

Comment by beutlich on 7 Aug 2014 11:15 UTC
VS build remark: If ModelicaStandardTables is compiled as DLL the linker option /OPT:REF must not be set. Otherwise the module constructor (i.e. InitializeCriticalSection) is not called.