Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TerminalBox issue #1706

Closed
modelica-trac-importer opened this issue Jan 15, 2017 · 5 comments
Closed

TerminalBox issue #1706

modelica-trac-importer opened this issue Jan 15, 2017 · 5 comments
Assignees
Labels
bug Critical/severe issue L: Electrical.Machines Issue addresses Modelica.Electrical.Machines
Milestone

Comments

@modelica-trac-importer
Copy link

Reported by anonymous on 24 Apr 2015 18:17 UTC
The Modelica.electrical.Machines.Utilities.TerminalBox definition has an icon that is partly outside (below) its extent rectangle.
This implies strange things with some tools such as OpenModelica.
Indeed if one wants to see the terminalBox parameters and double-clicks on the lower part of the icon, nothing occurs.
If, on the other hand, the user clicks on the upper part of the terminal-box sees the active rectangle of the component that is nearly totally displayed upper the icon.

This does not seem an OpenModelica issue.

In my opinion, terminalBox should be treated as Modelica.Electrical.Mulfiphase.Basic.PlugToPin_p, that is similar since it is small with respect to the extent rectangle.
I mean, the whole icon should be inside the extent rectangle; in this case well inside that rectangle.
I will attach (box.mo) an implementation of my proposed modification.


Migrated-From: https://trac.modelica.org/Modelica/ticket/1706

@modelica-trac-importer modelica-trac-importer added bug Critical/severe issue L: Electrical.Machines Issue addresses Modelica.Electrical.Machines labels Jan 15, 2017
@modelica-trac-importer
Copy link
Author

Comment by ahaumer on 22 Jun 2015 15:30 UTC
You're right, we'll shift the icon, but we have to check and test whether this affects user models. Since this is only a cosmetic issue, the solution will be postponed from 3.2.1+build 3 to 3.2.2

@modelica-trac-importer
Copy link
Author

Modified by ahaumer on 22 Jun 2015 15:31 UTC

@modelica-trac-importer
Copy link
Author

Comment by christiankral on 31 Jul 2015 18:28 UTC
Changed icon and location of connectors in Electrical.Machines and Magnetic.QuasiStatic.FundamentalWave. All examples are adapted in order to again exactly overlay the connectors of the electric machine models and the terminal boxes.

This is just a conmetic fix which will affect only the layout of user models.

All changes are performed in e21e5a8.

@modelica-trac-importer
Copy link
Author

Modified by beutlich on 23 Oct 2015 10:20 UTC

@modelica-trac-importer
Copy link
Author

Changelog modified by beutlich on 23 Oct 2015 10:20 UTC
Changed the TerminalBox icon and connector positions in Modelica.Electrical.Machines and Modelica.Magnetic.QuasiStatic.FundamentalWave

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Critical/severe issue L: Electrical.Machines Issue addresses Modelica.Electrical.Machines
Projects
None yet
Development

No branches or pull requests

6 participants