Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unnecessary hiding of results? #1764

Closed
modelica-trac-importer opened this issue Jan 15, 2017 · 4 comments
Closed

Unnecessary hiding of results? #1764

modelica-trac-importer opened this issue Jan 15, 2017 · 4 comments
Assignees
Labels
bug Critical/severe issue
Milestone

Comments

@modelica-trac-importer
Copy link

Reported by hansolsson on 21 Aug 2015 14:59 UTC
In MSL the block Modelica.Blocks.Routing.RealPassThrough
has annotation(HideResult=true) on its input and output.

I don't see the reason for that.

I can understand that you in some cases are uninterested in these variables, but I don't see why this block should always hide these variables - since the user adds them. For the use case of re-routing a user can just make these components "protected" if needed (e.g. in Modelica.Mechanics.MultiBody.Examples.Systems.RobotR3.Components.PathToAxisControlBus), and the other routing blocks don't hide connectors.

Additionally this would allow it to extend from SISO, and use RealPassThrough as a default replaceable "filter" component for real signals - instead of using Gain(k=1).

Basically HideResult should in my opinion only be used to hide confusing variables (as in StateGraph and unit-conversion variables, and connectorSizing-parameters), and in some cases for evaluated parameters that are obviously redundant (like useSupport).

I searched in MSL for other uses of HideResult, and I don't know about the following:
Modelica.Fluid.Fittings.BaseClasses.QuadraticTurbulent.BaseModel*
Modelica.Fluid.Fittings.GenericResistances.VolumeFlowRate
Modelica.Fluid.Interfaces.PartialPressureLoss
Modelica.Magnetic.FluxTubes.Basic.EddyCurrent
Modelica.Mechanics.MultiBody.Joints.Internal.*

I don't see showing those evaluated parameters as more confusing than the rest of the model - but I haven't investigated fully.

All other uses seem ok.


Migrated-From: https://trac.modelica.org/Modelica/ticket/1764

@modelica-trac-importer modelica-trac-importer added bug Critical/severe issue L: Blocks Issue addresses Modelica.Blocks labels Jan 15, 2017
@modelica-trac-importer
Copy link
Author

Modified by beutlich on 26 Oct 2015 20:18 UTC

@modelica-trac-importer modelica-trac-importer added this to the MSL3.2.2 milestone Jan 15, 2017
@modelica-trac-importer
Copy link
Author

Comment by otter on 11 Dec 2015 14:35 UTC
Fixed in 08a881f by removing the HideResult=true annotations

@modelica-trac-importer
Copy link
Author

Changelog modified by otter on 11 Dec 2015 14:35 UTC
Removed unnecessary HideResult=true annotations in several models

@modelica-trac-importer
Copy link
Author

Modified by beutlich on 13 Dec 2015 11:25 UTC

@modelica-trac-importer modelica-trac-importer removed the L: Blocks Issue addresses Modelica.Blocks label Jan 15, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Critical/severe issue
Projects
None yet
Development

No branches or pull requests

2 participants