You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Reported by hansolsson on 21 Aug 2015 14:59 UTC
In MSL the block Modelica.Blocks.Routing.RealPassThrough
has annotation(HideResult=true) on its input and output.
I don't see the reason for that.
I can understand that you in some cases are uninterested in these variables, but I don't see why this block should always hide these variables - since the user adds them. For the use case of re-routing a user can just make these components "protected" if needed (e.g. in Modelica.Mechanics.MultiBody.Examples.Systems.RobotR3.Components.PathToAxisControlBus), and the other routing blocks don't hide connectors.
Additionally this would allow it to extend from SISO, and use RealPassThrough as a default replaceable "filter" component for real signals - instead of using Gain(k=1).
Basically HideResult should in my opinion only be used to hide confusing variables (as in StateGraph and unit-conversion variables, and connectorSizing-parameters), and in some cases for evaluated parameters that are obviously redundant (like useSupport).
I searched in MSL for other uses of HideResult, and I don't know about the following:
Modelica.Fluid.Fittings.BaseClasses.QuadraticTurbulent.BaseModel*
Modelica.Fluid.Fittings.GenericResistances.VolumeFlowRate
Modelica.Fluid.Interfaces.PartialPressureLoss
Modelica.Magnetic.FluxTubes.Basic.EddyCurrent
Modelica.Mechanics.MultiBody.Joints.Internal.*
I don't see showing those evaluated parameters as more confusing than the rest of the model - but I haven't investigated fully.
Reported by hansolsson on 21 Aug 2015 14:59 UTC
In MSL the block Modelica.Blocks.Routing.RealPassThrough
has annotation(HideResult=true) on its input and output.
I don't see the reason for that.
I can understand that you in some cases are uninterested in these variables, but I don't see why this block should always hide these variables - since the user adds them. For the use case of re-routing a user can just make these components "protected" if needed (e.g. in Modelica.Mechanics.MultiBody.Examples.Systems.RobotR3.Components.PathToAxisControlBus), and the other routing blocks don't hide connectors.
Additionally this would allow it to extend from SISO, and use RealPassThrough as a default replaceable "filter" component for real signals - instead of using Gain(k=1).
Basically HideResult should in my opinion only be used to hide confusing variables (as in StateGraph and unit-conversion variables, and connectorSizing-parameters), and in some cases for evaluated parameters that are obviously redundant (like useSupport).
I searched in MSL for other uses of HideResult, and I don't know about the following:
Modelica.Fluid.Fittings.BaseClasses.QuadraticTurbulent.BaseModel*
Modelica.Fluid.Fittings.GenericResistances.VolumeFlowRate
Modelica.Fluid.Interfaces.PartialPressureLoss
Modelica.Magnetic.FluxTubes.Basic.EddyCurrent
Modelica.Mechanics.MultiBody.Joints.Internal.*
I don't see showing those evaluated parameters as more confusing than the rest of the model - but I haven't investigated fully.
All other uses seem ok.
Migrated-From: https://trac.modelica.org/Modelica/ticket/1764
The text was updated successfully, but these errors were encountered: