Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CombiTable1Ds returns allocation error, but no allocation error occurs #1820

Closed
modelica-trac-importer opened this issue Jan 15, 2017 · 9 comments
Closed

CombiTable1Ds returns allocation error, but no allocation error occurs #1820

modelica-trac-importer opened this issue Jan 15, 2017 · 9 comments
Assignees
@beutlich
Labels
bug Critical/severe issue L: C-Sources Issue addresses Modelica/Resources/C-Sources P: high High priority issue
Milestone
MSL3.2.2

Comments

@modelica-trac-importer
Copy link

Reported by sjoelund.se on 5 Nov 2015 10:54 UTC
CombiTable1Ds returns allocation error, but no allocation error occurs.

See om:#3542 for the original source code and ticket. @beutlich initial feedback was:

Only one row, but Akima interpolation wanted?

So it seems the error message is wrong, but so is the model. The question is what to do about it?

Migrated-From: https://trac.modelica.org/Modelica/ticket/1820
@modelica-trac-importer modelica-trac-importer added this to the MSL3.2.2 milestone Jan 15, 2017
@modelica-trac-importer modelica-trac-importer added bug Critical/severe issue L: C-Sources Issue addresses Modelica/Resources/C-Sources P: high High priority issue labels Jan 15, 2017
@modelica-trac-importer
Copy link
Author

Modified by beutlich on 5 Nov 2015 11:01 UTC

@modelica-trac-importer
Copy link
Author

Comment by beutlich on 5 Nov 2015 11:04 UTC
The idea is to change interpolation kind to constant interpolation if only one row is given. This already is done similarly for tables with two rows where interpolation is silently switched from Akima to linear.

Instead of the silent change of the interpolation kind a (new) warning should also be issued if the verbose flag ist set.

@modelica-trac-importer
Copy link
Author

Comment by beutlich on 5 Nov 2015 13:05 UTC
Resolved by 2f60418 (but w/o the verbose messages which would require new API functions :-().

@modelica-trac-importer
Copy link
Author

Changelog modified by beutlich on 5 Nov 2015 13:05 UTC
Modelica Standard Tables: Added support of 1D tables with single row and spline interpolation

@modelica-trac-importer
Copy link
Author

Comment by beutlich on 5 Nov 2015 14:14 UTC
I now see clearer, 2f18b89 indeed introduced the wrong error message here.

Can solve it differently.

@modelica-trac-importer
Copy link
Author

Changelog removed by beutlich on 5 Nov 2015 14:14 UTC

@modelica-trac-importer
Copy link
Author

Comment by beutlich on 5 Nov 2015 15:22 UTC
It's even worse: CombiTable2D with 2x3 or 3x2 tables gives same error (in trunk) and crashes in maint. branch.

@modelica-trac-importer
Copy link
Author

Comment by beutlich on 16 Nov 2015 15:59 UTC
Finally resolved by 4fa8b48.
Added new test models by c6e3f5d.

@modelica-trac-importer
Copy link
Author

Changelog modified by beutlich on 16 Nov 2015 15:59 UTC
Modelica Standard Tables: Fixed support of 2x3 and 3x2 2D tables with spline interpolation

Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@beutlich beutlich

Labels
bug Critical/severe issue L: C-Sources Issue addresses Modelica/Resources/C-Sources P: high High priority issue
Projects
None yet
Milestone
MSL3.2.2
Development

No branches or pull requests
2 participants
@beutlich @modelica-trac-importer