Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bug in Modelica.Fluid.Pipes.DynamicPipe #215

Closed
modelica-trac-importer opened this issue Jan 13, 2017 · 4 comments
Closed

bug in Modelica.Fluid.Pipes.DynamicPipe #215

modelica-trac-importer opened this issue Jan 13, 2017 · 4 comments
Labels
bug Critical/severe issue L: Fluid Issue addresses Modelica.Fluid (excl. Dissipation)
Milestone

Comments

@modelica-trac-importer
Copy link

Reported by kilian_link on 23 Sep 2009 15:23 UTC
discretization of linear pressure drop correlation fails, i.e. linear pressure drop depends on nNodes and is wrong for nNodes>1


Migrated-From: https://trac.modelica.org/Modelica/ticket/215

@modelica-trac-importer modelica-trac-importer added bug Critical/severe issue L: Fluid Issue addresses Modelica.Fluid (excl. Dissipation) labels Jan 13, 2017
@modelica-trac-importer
Copy link
Author

Comment by kilian_link on 1 Oct 2009 09:32 UTC
Fixed bug in Modelica.Fluid.Pipes.BaseClasses.FlowModels.NominalLaminarFlow and its sub models to work correctly with the DynamicPipe model. Changes might corrupt other models, hence this should be double checked by an expert.

Modelica.Fluid.Pipes.BaseClasses.FlowModels.NominalTurbulentPipeFlow seems to be still buggy and should be fixed by someone who is familar with the model layout in Fluid.

@modelica-trac-importer
Copy link
Author

Comment by rfranke on 2 Oct 2009 13:59 UTC
Thank you for the investigation of the DynamicPipe model and for the example testDynamicPipeLinearPressureLoss.mo illustrating your issue.

It turns out that there were two bugs in the NominalLaminarFlow model:

  1. the number of flow segments was not considered
  2. the number of parallel pipes was considered incorrectly.
    Thank you for the fix.

The NominalTurbulentPipeFlow model was facing the first bug only. It now considers the number of flow segments as well. The NominalTurbulentPipeFlow model is more complex because it uses the regular TurbulentPipeFlow and adapts the pipe length such that the specified nominal pressure drop is fulfilled.

This ticket also covers another bug: the consideration of the number of parallel pipes for the velocity of fluid flow. The flow velocity should not be adapted in the flow model, but in the overall pipe models. Also there one wants to see the correct velocity. This is why I reverted your changes in PartialStaggeredFlowModel. The pipe models PartialTwoPortFlow (base class of DynamicPipe) and StaticPipe have been corrected instead.

See SVN, 9663715.

@modelica-trac-importer
Copy link
Author

Comment by dietmarw on 2 Oct 2009 15:50 UTC
Was also applied to maintenance/3.1 (d3d07d9).

@modelica-trac-importer
Copy link
Author

Comment by dietmarw on 25 Nov 2009 11:53 UTC
Milestone MSL3.1.1 deleted

@modelica-trac-importer modelica-trac-importer added this to the MSL3.2 milestone Jan 13, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Critical/severe issue L: Fluid Issue addresses Modelica.Fluid (excl. Dissipation)
Projects
None yet
Development

No branches or pull requests

2 participants