Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing initial assignments in Modelica.Fluid.Examples.ControlledTankSystem.ControlledTanks #2243

Closed
beutlich opened this issue Apr 24, 2017 · 2 comments
Assignees
Labels
bug Critical/severe issue example Issue only addresses example(s) L: Fluid Issue addresses Modelica.Fluid (excl. Dissipation)
Milestone

Comments

@beutlich
Copy link
Member

The test model T2243 is a reduced model of Modelica.Fluid.Examples.ControlledTankSystem.ControlledTanks and gives warnings about missing initial assignments

model T2243
  Modelica.Fluid.Examples.ControlledTankSystem.Utilities.RadioButton start(reset={stop.on,shut.on}, buttonTimeTable={20,280})
    annotation (Placement(transformation(extent={{-66,40},{-46,60}})));
  Modelica.Fluid.Examples.ControlledTankSystem.Utilities.RadioButton stop(reset={start.on,shut.on}, buttonTimeTable={220,650})
    annotation (Placement(transformation(extent={{-66,10},{-46,30}})));
  Modelica.Fluid.Examples.ControlledTankSystem.Utilities.RadioButton shut(reset={start.on,stop.on}, buttonTimeTable={700})
    annotation (Placement(transformation(extent={{-66,-20},{-46,0}})));
  annotation (uses(Modelica(version="3.2.2")), experiment(StopTime=900));
end T2243;

The reason is that in RadioButton only the pre-values of reset are assigned since f090fb3.

@beutlich beutlich added the L: Fluid Issue addresses Modelica.Fluid (excl. Dissipation) label Apr 24, 2017
@beutlich beutlich added this to the MSL_next-MINOR-version milestone Apr 24, 2017
@beutlich beutlich added the bug Critical/severe issue label Aug 5, 2017
@beutlich beutlich added the example Issue only addresses example(s) label May 28, 2018
@MartinOtter
Copy link
Member

I am analysing this model since some time and do not understand why initial conditions are missing. For example, Dymola reports missing initial condition for start.table.y. However, there are the continuous time equations:

start.table.y = start.table.combiTable.y >= 0.5
start.table.combiTable.y = <continuous time equation>

This means start.table.y is well-defined also during initiatialization. This might be an issue with the tool. Therefore, I have added Hans as further Assignee.

@HansOlsson
Copy link
Contributor

I have soon made the pull request.

@beutlich beutlich added bug Critical/severe issue and removed bug Critical/severe issue labels Jun 14, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Critical/severe issue example Issue only addresses example(s) L: Fluid Issue addresses Modelica.Fluid (excl. Dissipation)
Projects
None yet
Development

No branches or pull requests

3 participants