Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

FluidHeatFlow.Sources.IdealPump: equations have a flaw #2549

Closed
AHaumer opened this issue May 26, 2018 · 2 comments · Fixed by #2701
Closed

FluidHeatFlow.Sources.IdealPump: equations have a flaw #2549

AHaumer opened this issue May 26, 2018 · 2 comments · Fixed by #2701
Assignees
@AHaumer
Labels
bug Critical/severe issue L: Thermal.FluidHeatFlow Issue addresses Modelica.Thermal.FluidHeatFlow
Milestone
MSL3.2.3

Comments

@AHaumer
Copy link
Contributor

AHaumer commented May 26, 2018

The dependency of pressure increase versus volumeFlow is (according to Euler) linear without the abs around volumeFlow.
To get volumeFlow negative, the pressure increase has to get higher than at zero flow.
@AHaumer AHaumer added bug Critical/severe issue L: Thermal.FluidHeatFlow Issue addresses Modelica.Thermal.FluidHeatFlow V: 3.2.2 Issue originates in MSL v3.2.2 (and is not present in earlier releases) labels May 26, 2018
@AHaumer AHaumer added this to the MSL3.2.3 milestone May 26, 2018
@AHaumer AHaumer self-assigned this May 26, 2018
@beutlich beutlich mentioned this issue Aug 5, 2018
Closed
@beutlich
Copy link
Member

beutlich commented Aug 5, 2018

Reopen, since the fix in b7a64818aba4bf6375ba013b18b5afa2daa439d1was later reverted by dfa793f. Issue will be closed automatically once #2688 gets merged.

@beutlich beutlich reopened this Aug 5, 2018
@beutlich beutlich removed the V: 3.2.2 Issue originates in MSL v3.2.2 (and is not present in earlier releases) label Aug 5, 2018
@beutlich
Copy link
Member

beutlich commented Aug 5, 2018

Removed the V: 3.2.2 label since the issue is present since 60f640b (MSL v2.2.1) where IdealPump was added.

@AHaumer AHaumer mentioned this issue Aug 6, 2018
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@AHaumer AHaumer

Labels
bug Critical/severe issue L: Thermal.FluidHeatFlow Issue addresses Modelica.Thermal.FluidHeatFlow
Projects
None yet
Milestone
MSL3.2.3
Development

Successfully merging a pull request may close this issue.

Fix equation of pressure increase versus volume flow in IdealPump
resolves #2687
2 participants
@AHaumer @beutlich