Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Further improvements of toUpperHessenberg #2692

Closed
HansOlsson opened this issue Jul 17, 2018 · 1 comment · Fixed by #3196
Closed

Further improvements of toUpperHessenberg #2692

HansOlsson opened this issue Jul 17, 2018 · 1 comment · Fixed by #3196
Assignees
@HansOlsson
Labels
documentation Issue addresses the documentation example Issue only addresses example(s) L: Math Issue addresses Modelica.Math P: low Low priority issue
Milestone
MSL4.0.0

Comments

@HansOlsson
Copy link
Contributor

HansOlsson commented Jul 17, 2018 •
edited

So that we don't miss the items detected in #2691 (these also apply to the related functions).

  • Missing test-cases for non-default ilo, ihi.

  • Documentation of ilo and ihi is unclear; basically the matrix is in supposed to be in BLT-form where the parts before and after ilo:ihi are already upper triangular and we only have to transform that sub-matrix.

In retrospect not exposing ilo and ihi had probably been a wiser choice, but removing them now seems more problematic.
(Removing the last column of V just seems to cause problems for no real gain.)
@HansOlsson HansOlsson added L: Math Issue addresses Modelica.Math P: low Low priority issue documentation Issue addresses the documentation example Issue only addresses example(s) labels Jul 17, 2018
@beutlich beutlich added this to the MSL_next-MAJOR-version milestone Sep 26, 2018
@beutlich
Copy link
Member

beutlich commented Nov 2, 2019

@HansOlsson Friendly reminder.

@HansOlsson HansOlsson mentioned this issue Nov 4, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@HansOlsson HansOlsson

Labels
documentation Issue addresses the documentation example Issue only addresses example(s) L: Math Issue addresses Modelica.Math P: low Low priority issue
Projects
None yet
Milestone
MSL4.0.0
Development

Successfully merging a pull request may close this issue.

Improve upper Hessenberg; document and test ilo/ihi HansOlsson/Modelica
2 participants
@HansOlsson @beutlich