Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename parameter tau_constant #2863

Closed
tobolar opened this issue Mar 26, 2019 · 0 comments · Fixed by #2912
Closed

Rename parameter tau_constant #2863

tobolar opened this issue Mar 26, 2019 · 0 comments · Fixed by #2912
Assignees
@tobolar
Labels
L: Mechanics.Rotational Issue addresses Modelica.Mechanics.Rotational task General work that is not related to a bug or feature
Milestone
MSL4.0.0

Comments

@tobolar
Copy link
Contributor

tobolar commented Mar 26, 2019

In Modelica.Mechanics.Rotational.Sources.SignTorque, the parameter tau_constant shall be renamed to tau_nominal, similarly to e.g. LinearSpeedDependentTorque class.
@tobolar tobolar added the L: Mechanics.Rotational Issue addresses Modelica.Mechanics.Rotational label Mar 26, 2019
@tobolar tobolar added this to the MSL4.0.0 milestone Mar 26, 2019
@tobolar tobolar self-assigned this Mar 26, 2019
@tobolar tobolar mentioned this issue Mar 26, 2019
Merged
@tobolar tobolar mentioned this issue May 3, 2019
Merged
@beutlich beutlich added the task General work that is not related to a bug or feature label May 6, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@tobolar tobolar

Labels
L: Mechanics.Rotational Issue addresses Modelica.Mechanics.Rotational task General work that is not related to a bug or feature
Projects
None yet
Milestone
MSL4.0.0
Development

Successfully merging a pull request may close this issue.

Rename tau_constant to tau_nominal
2 participants
@tobolar @beutlich