Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Confusing description of angles_start in Modelica.Mechanics.MultiBody.Parts.Body #3157

Closed
otronarp opened this issue Oct 18, 2019 · 0 comments · Fixed by #3364
Closed

Confusing description of angles_start in Modelica.Mechanics.MultiBody.Parts.Body #3157

otronarp opened this issue Oct 18, 2019 · 0 comments · Fixed by #3364
Assignees
@tobolar
Labels
L: Mechanics.MultiBody Issue addresses Modelica.Mechanics.MultiBody
Milestone
MSL4.0.0

Comments

@otronarp
Copy link
Member

The description for angles_start in Modelica.Mechanics.MultiBody.Parts.Body reads:

"Initial values of angles to rotate frame_a around 'sequence_start' axes into frame_b"

Which is a bit confusing since there is no frame_b in Modelica.Mechanics.MultiBody.Parts.Body.

That description is also propagated to angles_start in BodyShape, BodyBox and BodyCylinder. Which is even more confusing since they have a frame_b, but that comment is for the non-existing frame_b in their internal Body instance.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@tobolar tobolar

Labels
L: Mechanics.MultiBody Issue addresses Modelica.Mechanics.MultiBody
Projects
None yet
Milestone
MSL4.0.0
Development

Successfully merging a pull request may close this issue.

Fix false description of parameters angles_start and sequence_start
4 participants
@otronarp @MartinOtter @tobolar @beutlich