Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Unit in FluidDissipation correlation #502

Closed
modelica-trac-importer opened this issue Jan 14, 2017 · 4 comments
Closed

Unit in FluidDissipation correlation #502

modelica-trac-importer opened this issue Jan 14, 2017 · 4 comments
Assignees
@wischhusen
Labels
bug Critical/severe issue L: Fluid.Dissipation Issue addresses Modelica.Fluid.Dissipation
Milestone
MSL3.2.1

Comments

@modelica-trac-importer
Copy link

Reported by msielemann on 3 Mar 2011 10:31 UTC
For the Gungor/Winterton correlation in HeatTransfer.StraightPipe.kc_twoPhase_overall_KC, the molar mass has to be supplied in g/mol. This is also done for the validation plots. Note that the List of Symbols in Bejan, which mentions kg/mol, thus seems to be erroneous.

In FluidDissipation, the unit attribute of SI.MolarMass prescribes kg/mol however. Preferably, the implementation of the correlation should therefore do a conversion from kg/mol to g/mol locally.

Migrated-From: https://trac.modelica.org/Modelica/ticket/502
@modelica-trac-importer modelica-trac-importer added bug Critical/severe issue L: Fluid.Dissipation Issue addresses Modelica.Fluid.Dissipation labels Jan 14, 2017
@modelica-trac-importer
Copy link
Author

Comment by wischhusen on 11 Apr 2012 13:13 UTC
Introduced a local type Modelica.Fluid.Dissipation.Utilities.Types.MolarMass_gpmol.

@modelica-trac-importer
Copy link
Author

Modified by wischhusen on 11 Apr 2012 13:15 UTC

@modelica-trac-importer
Copy link
Author

Comment by dietmarw on 11 Apr 2012 13:46 UTC
Is the revision number known in which this new type was added?

@modelica-trac-importer
Copy link
Author

Comment by dietmarw on 11 Apr 2012 20:47 UTC
Fixed in 5b96428

@modelica-trac-importer modelica-trac-importer added this to the MSL3.2.1 milestone Jan 14, 2017
Closed
@modelica-trac-importer modelica-trac-importer modified the milestone: MSL3.2.1 Jan 14, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@wischhusen wischhusen

Labels
bug Critical/severe issue L: Fluid.Dissipation Issue addresses Modelica.Fluid.Dissipation
Projects
None yet
Milestone
MSL3.2.1
Development

No branches or pull requests
2 participants
@wischhusen @modelica-trac-importer