Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing icons for packages, functions and records #782

Closed
modelica-trac-importer opened this issue Jan 14, 2017 · 5 comments
Closed

Missing icons for packages, functions and records #782

modelica-trac-importer opened this issue Jan 14, 2017 · 5 comments
Assignees
Labels
bug Critical/severe issue L: Electrical.Spice3 Issue addresses Modelica.Electrical.Spice3
Milestone

Comments

@modelica-trac-importer
Copy link

Reported by dietmarw on 23 Jul 2012 10:39 UTC
There are a couple of extends for the icon definitions missing. All packages, functions and records which don't have a custom icon themselves should extend from either

  • Modelica.Icons.Package
  • Modelica.Icons.Function
  • Modelica.Icons.Record
    respectively.

Migrated-From: https://trac.modelica.org/Modelica/ticket/782

@modelica-trac-importer modelica-trac-importer added this to the MSL3.2.1 milestone Jan 14, 2017
@modelica-trac-importer modelica-trac-importer added bug Critical/severe issue L: Electrical.Spice3 Issue addresses Modelica.Electrical.Spice3 labels Jan 14, 2017
@modelica-trac-importer
Copy link
Author

Comment by dietmarw on 31 Jul 2012 07:30 UTC
Just a small hint on how one can easily detect which classes need fixing by looking at the component tree in Dymola:

  1. Open the icon layer of Modelica.Icons.Function and change the colour to something that sticks out (or is very ugly).
  2. Do the same with Modelica.Icons.Record
  3. Now browse the sub-library which you think still has missing extend statements.
  4. All classes that don't have the necessary extend statements will now be displayed as usual by Dymola and all classes that are already fixed will have the ugly colour.
  5. Add the missing extend clauses to respective classes and save the changes. DO NOT SAVE Modelica.Icons.* as this was just a hack for detecting faulty classes.

As for Packages, just look for the old-style blue default display that differs from the new greyish design of Modelica.Icons.Package

@modelica-trac-importer
Copy link
Author

Comment by majetta on 31 Jul 2012 09:58 UTC
The functions, packages and records now extend from Modelica.Icons.
REVIEW d0d5e00 and r5337

@modelica-trac-importer
Copy link
Author

Comment by dietmarw on 31 Jul 2012 10:40 UTC
OK some packages were forgotten,
DONE in 371e989 and r5341.

@modelica-trac-importer
Copy link
Author

Modified by majetta on 5 Apr 2013 12:27 UTC

@modelica-trac-importer
Copy link
Author

Changelog modified by majetta on 5 Apr 2013 12:27 UTC
extends for the icon definitions added

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Critical/severe issue L: Electrical.Spice3 Issue addresses Modelica.Electrical.Spice3
Projects
None yet
Development

No branches or pull requests

2 participants