Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GravityTypes referred to as Integer #803

Closed
modelica-trac-importer opened this issue Jan 14, 2017 · 1 comment
Closed

GravityTypes referred to as Integer #803

modelica-trac-importer opened this issue Jan 14, 2017 · 1 comment
Assignees
Labels
bug Critical/severe issue L: Mechanics.MultiBody Issue addresses Modelica.Mechanics.MultiBody
Milestone

Comments

@modelica-trac-importer
Copy link

Reported by sjoelund.se on 7 Sep 2012 08:26 UTC
GravityTypes in the World object is defined as an enumeration but it is used or referred to as an Integer:

$ grep -nR "gravityType=[0-9]" libraries/ | grep -v svn | grep -v "Modelica 3.1"
libraries/ModelicaTest 1.1/MultiBody.mo:3523:                                  animateWorld=false, gravityType=0)
libraries/ModelicaTest 1.1/MultiBody.mo:6028:                                  animateWorld=false, gravityType=0)
libraries/Modelica 3.2.1/Mechanics/MultiBody/package.mo:1273:      "Constant gravity acceleration, resolved in world frame, if gravityType=1";
libraries/Modelica 3.2.1/Mechanics/MultiBody/package.mo:1275:      "Field constant of point gravity field, if gravityType=2";

ModelicaTest needs to be updated to be legal Modelica. And the documentation strings should be updated.

I did not update any code because 0 is not a valid enumeration index.


Migrated-From: https://trac.modelica.org/Modelica/ticket/803

@modelica-trac-importer modelica-trac-importer added this to the MSL3.2.1 milestone Jan 14, 2017
@modelica-trac-importer modelica-trac-importer added bug Critical/severe issue L: Mechanics.MultiBody Issue addresses Modelica.Mechanics.MultiBody labels Jan 14, 2017
@modelica-trac-importer
Copy link
Author

Comment by hansolsson on 5 Dec 2012 16:40 UTC
Fixed in MSL; ticket was not updated.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Critical/severe issue L: Mechanics.MultiBody Issue addresses Modelica.Mechanics.MultiBody
Projects
None yet
Development

No branches or pull requests

2 participants