Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Modelica.Mechanics.Translational.Components.ElastoGap c and d parameters need types #873

Closed
modelica-trac-importer opened this issue Jan 14, 2017 · 2 comments
Closed

Modelica.Mechanics.Translational.Components.ElastoGap c and d parameters need types #873

modelica-trac-importer opened this issue Jan 14, 2017 · 2 comments
Assignees
@AHaumer
Labels
enhancement New feature or enhancement L: Mechanics.Translational Issue addresses Modelica.Mechanics.Translational
Milestone
MSL3.2.1

Comments

@modelica-trac-importer
Copy link

Reported by jriel on 12 Oct 2012 18:50 UTC
The c and d parameters are specified as

  parameter Real c(final unit="N/m", final min=0, start=1) "Spring constant";
  parameter Real d(final unit="N/ (m/s)", final min=0, start=1) "Damping constant";

Rather than Real, they should be declared as

  parameter SI.TranslationalSpringConstant c(final min=0, start = 1) "Spring constant";
  parameter SI.TranslationalDampingConstant d(final min=0, start = 1) "Damping constant";

Migrated-From: https://trac.modelica.org/Modelica/ticket/873
@modelica-trac-importer modelica-trac-importer added bug Critical/severe issue L: Mechanics.Translational Issue addresses Modelica.Mechanics.Translational labels Jan 14, 2017
@modelica-trac-importer
Copy link
Author

Comment by dietmarw on 12 Oct 2012 19:04 UTC
FIXED in f34cbcc

@modelica-trac-importer
Copy link
Author

Changelog modified by dietmarw on 12 Oct 2012 19:04 UTC
Enhanced ElastoGap parameters by usage of SIunits.

@modelica-trac-importer modelica-trac-importer added this to the MSL3.2.1 milestone Jan 14, 2017
@modelica-trac-importer modelica-trac-importer added enhancement New feature or enhancement and removed bug Critical/severe issue labels Jan 14, 2017
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@AHaumer AHaumer

Labels
enhancement New feature or enhancement L: Mechanics.Translational Issue addresses Modelica.Mechanics.Translational
Projects
None yet
Milestone
MSL3.2.1
Development

No branches or pull requests
2 participants
@AHaumer @modelica-trac-importer