New components are missing test models

[modelica-trac-importer]

Reported by dietmarw on 8 Feb 2013 15:51 UTC
As discussed on the Modelica design list new additions to the MSL should always come with test models (see Proposal for MSL additions and conformance testing) .

In 7967343 3 new components were introduced to the library but without a reflective test model in ModelicaTest:

• Modelica.Electrical.Machines.Utilities.DqController
• Modelica.Electrical.Machines.Utilities.ToDQ
• Modelica.Electrical.Machines.Utilities.FromDQ

In addition DqController has even some more issues, see #982.

So either some test models are provided or these new components need to be removed again. This then also means that the new example model SMPM_VoltageSource needs to be removed. But I hope this will not be necessary.

---

Migrated-From: https://trac.modelica.org/Modelica/ticket/983

[modelica-trac-importer]

Comment by ahaumer on 25 Feb 2013 14:36 UTC
I can remember (correct me if I'm wrong) that not all models need a test case, especially those in "Utilities". Additionally, we could test more than one model together if it makes sense (how should we test a single resistor without ground and source?) - this is the case for those models. They are tested in Examples.SynchronousInductionmachines.SMPM_VoltageSource. I thought that the Examples (with unambiguous initialization!) are part of the Test suite.

[modelica-trac-importer]

Comment by dietmarw on 25 Feb 2013 15:26 UTC
The reasoning was that every new component at least should have a test model in which it is used. That way we can document the quality and also test this on possible updated fixes later that nothing gets broken. In this case the it might actually be sufficient that the component is used in an example that will be executed for testing.