Skip to content
This repository has been archived by the owner on Feb 10, 2022. It is now read-only.

FMI Standard Tool listing shows "passed" despite "notCompliantWithLatestTestRules" file #69

Closed
ghorwin opened this issue Aug 5, 2019 · 2 comments

Comments

@ghorwin
Copy link
Contributor

ghorwin commented Aug 5, 2019

For example:

results/2.0/cs/linux64/SIMPACK/9.10.1/JModelica.org/1.15/ControlledTemperature/

Directory contains both passed and notCompliantWithLatestRules files. Fmi-Tools-Listing shows corresponding case still as validated (btw, results are way off, so 'failed' would have been the appropriate rating).

Currently, the webpage display does not allow to distinguish between "had been validated with previous set of cross-check-rules" and "does comply to current cross-check-rules".

Suggest: add special handling in validate_vendor_repo script.

Problem appears to be in lines 277-278:validate_vendor_repo.py where

        if new_problems and clean_up:
            not_compliant_file = os.path.join(subdir, 'notCompliantWithLatestRules')

notCompliant... file is only tested for, when running with cleanup and when problems were found.
Maybe the check for 'notComplient' could be moved ahead and the test case should be skipped alltogether if the file is present?

(Note to self: I guess I have to read up on the discussion on that issue in the meeting notes... :-) )

@lochel
Copy link
Member

lochel commented Jul 13, 2021

This issue is concerning. Can please someone comment on it? Does the described issue actually falsify the displayed results?

@lochel
Copy link
Member

lochel commented Jul 23, 2021

@ghorwin I think this is finally fixed and can be closed. See #129 (comment)

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants