Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove uses of __Dymola_choicesFromPackage annotation #27

Closed
harmanpa opened this issue Jun 7, 2018 · 2 comments
Closed

Remove uses of __Dymola_choicesFromPackage annotation #27

harmanpa opened this issue Jun 7, 2018 · 2 comments
Assignees

Comments

@harmanpa
Copy link
Member

harmanpa commented Jun 7, 2018

The tool-specific annotation __Dymola_choicesFromPackage is used in the classes VehicleInterfaces.DriverEnvironments.DriveByWireAutomatic and VehicleInterfaces.Drivers.MinimalDriver

@tobolar
Copy link
Contributor

tobolar commented Jun 8, 2018

Just to be sure, what is the motivation of this issue? Tool-specific annotations are generally allowed in the models. Or is it obsolete Dymola annotation?

@harmanpa
Copy link
Member Author

harmanpa commented Jun 8, 2018

In this case it is used as part of #25 - part of a fudge to achieve enumerations before they were in the standard. But also this is the only library I know of using this annotation, and while choicesAllMatching was standardised, choicesFromPackage wasn't, so I'd consider it kind of obsolete.

@tobolar tobolar self-assigned this Jun 8, 2018
harmanpa added a commit that referenced this issue Jun 21, 2018
Remove usage of __Dymola_choicesFromPackage, see #27
tobolar added a commit that referenced this issue Jun 21, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants