Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Duplicated theme_drwhy* #17

Closed
pbiecek opened this issue Jul 10, 2019 · 1 comment
Closed

Duplicated theme_drwhy* #17

pbiecek opened this issue Jul 10, 2019 · 1 comment

Comments

@pbiecek
Copy link
Member

pbiecek commented Jul 10, 2019

Currently in the shapper we have hard copies of drwhy themes

> library("shapper")
Attaching package: ‘shapper’
The following objects are masked from ‘package:DALEX’:
    theme_drwhy, theme_drwhy_colors, theme_drwhy_vertical

maybe we can use directly themes from DALEX package?
as it is done in iBreakDown
https://github.com/ModelOriented/iBreakDown/blob/master/R/plot_break_down.R#L25

this way we will not need to maintain separate copies of theme_*

@maksymiuks
Copy link
Member

Done, thanks :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants