Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Individual baselines #113

Closed
mayer79 opened this issue Oct 17, 2023 · 1 comment
Closed

Individual baselines #113

mayer79 opened this issue Oct 17, 2023 · 1 comment
Assignees
Labels
enhancement New feature or request long-term

Comments

@mayer79
Copy link
Collaborator

mayer79 commented Oct 17, 2023

The "shap" package in Python stores baseline values per observation, while {shapviz} stores a single value. In most of the cases, this will do the job, but the Python logic is more flexible.

We should probably switch to the more flexible solution. A lot of functions need to be adapted, but the change affects only two plot functions: sv_force() and sv_waterfall(). The other functions do not need a baseline.

See also the discussion here: #111 (comment)

@mayer79
Copy link
Collaborator Author

mayer79 commented Dec 31, 2023

Currently, I don't think we need to change the baseline logic. We can open the issue again, if there is a very good use case.

@mayer79 mayer79 closed this as not planned Won't fix, can't repro, duplicate, stale Dec 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request long-term
Projects
None yet
Development

No branches or pull requests

1 participant