Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

facet_ncol is missing in plot_individual_ceteris_paribus_survival #13

Closed
hbaniecki opened this issue Oct 21, 2022 · 1 comment · Fixed by #21
Closed

facet_ncol is missing in plot_individual_ceteris_paribus_survival #13

hbaniecki opened this issue Oct 21, 2022 · 1 comment · Fixed by #21
Labels
invalid ❕ This doesn't seem right

Comments

@hbaniecki
Copy link
Member

See

facet_wrap(~`_vname_`)

and
facet_wrap(~`_vname_`)

Also, should scales be used here?

facet_wrap(~`_vname_`, scales = "free_x", ncol = facet_ncol) +

@hbaniecki hbaniecki added the invalid ❕ This doesn't seem right label Oct 21, 2022
@mikolajsp
Copy link
Collaborator

Actually, I've removed the facet_ncol and title arguments from the plot_individual_ceteris_paribus_survival() function, as they are not needed. It always draws one subplot for one variable, and the faceting is only to get the name of the variable printed over the plot in the same way as the others. Faceting is done by another function.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
invalid ❕ This doesn't seem right
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants