Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cleaner csproj include generated files #229

Open
tompipe opened this issue Nov 13, 2019 · 1 comment
Open

Cleaner csproj include generated files #229

tompipe opened this issue Nov 13, 2019 · 1 comment

Comments

@tompipe
Copy link

tompipe commented Nov 13, 2019

After the VS extension generates models, it modifies the csproj to include the .generated.cs files under the DependentUpon:ModelsBuilder ItemGroup, adding an entry for each individual file.

This could be simplified with a wildcard, eg:

  <ItemGroup Label="DependentUpon:ModelsBuilder">
    <Compile Update="Models\Generated\*.generated.cs">
      <DesignTime>True</DesignTime>
      <AutoGen>True</AutoGen>
      <DependentUpon>_UmbracoModels.mb</DependentUpon>
    </Compile>    
  </ItemGroup>
@ronaldbarendse
Copy link

Wildcards don't work with the default project type, only on the new SDK-style projects. As Umbraco doens't support that yet (umbraco/Umbraco-CMS#3635), the generated files need to be included individually (but please feel free to prove me wrong).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants