Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Properties not available on interfaces with Document Type Compositions #16

Closed
jbreuer opened this issue Oct 28, 2014 · 1 comment
Closed
Assignees
Labels
Milestone

Comments

@jbreuer
Copy link

jbreuer commented Oct 28, 2014

I've been testing the Umbraco 7.2 beta with Document Type Compositions. When a Document Type inherits from multiple compositions it creates interfaces for these Document Types so it can inherit from these interfaces.

The properties on these interfaces are generated incorrectly. For example it generates the following:

// Mixin content Type 1204 with alias "Doc1"
/// <summary>Doc1</summary>
public partial interface IDoc1 : IPublishedContent
{
    /// <summary>Text1</summary>        string Text1 { get; }
}

/// <summary>Doc1</summary>
[PublishedContentModel("Doc1")]
public partial class Doc1 : PublishedContentModel, IDoc1

The Text1 property is on the same line as the summary and commented out because of that. If it's on a new line it works correctly.

The rest already works perfect. For example you can do something like this to get all the nodes that have a certain composition.

var docs = CurrentPage.Children<IDoc1>();
@zpqrtbnk zpqrtbnk added type/bug Bug and removed type/bug Bug labels Oct 29, 2014
@zpqrtbnk zpqrtbnk self-assigned this Oct 29, 2014
@zpqrtbnk
Copy link
Collaborator

Will fix asap.

zpqrtbnk pushed a commit that referenced this issue Oct 29, 2014
@zpqrtbnk zpqrtbnk added this to the 2.0.1 milestone Oct 29, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants