Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Initialize the CAPTCHA module with emoji CAPTCHA #25

Merged
merged 26 commits into from Sep 2, 2022
Merged

Initialize the CAPTCHA module with emoji CAPTCHA #25

merged 26 commits into from Sep 2, 2022

Conversation

roj1512
Copy link
Collaborator

@roj1512 roj1512 commented Sep 2, 2022 •
edited

  • Add environment variable for the API URL.
  • Make it only available if the environment variable is set.
  • Clean the filters.
  • Make the CAPTCHA type configurable.
  • Persist the CryptoKey to the database.
  • Add commands to change the CAPTCHA type.
  • Make the message texts better.
  • Send a message in the chat once the join request is approved?

@roj1512 roj1512 marked this pull request as draft September 2, 2022 12:49
dcdunkan
dcdunkan reviewed Sep 2, 2022
View reviewed changes
handlers/captcha.ts Outdated Show resolved Hide resolved
handlers/captcha.ts Outdated Show resolved Hide resolved
dcdunkan
dcdunkan reviewed Sep 2, 2022
View reviewed changes
handlers/captcha.ts Outdated Show resolved Hide resolved
dcdunkan
dcdunkan reviewed Sep 2, 2022
View reviewed changes
handlers/captcha/emoji.ts Outdated Show resolved Hide resolved
@roj1512 roj1512 marked this pull request as ready for review September 2, 2022 15:42
@roj1512 roj1512 requested a review from ArnabXD September 2, 2022 15:49
@roj1512
Copy link
Collaborator Author

roj1512 commented Sep 2, 2022 •
edited

  • Don't store the AES CBC key in localStorage as it is not supported on Deno Deploy.

@roj1512
Copy link
Collaborator Author

roj1512 commented Sep 2, 2022 •
edited

Emoji CAPTCHA API spec & implementation: https://github.com/roj1512/emoji-captcha

ArnabXD
ArnabXD reviewed Sep 2, 2022
View reviewed changes
database/operations/kv.ts Outdated Show resolved Hide resolved
ArnabXD
ArnabXD reviewed Sep 2, 2022
View reviewed changes
database/operations/kv.ts Outdated Show resolved Hide resolved
ArnabXD
ArnabXD reviewed Sep 2, 2022
View reviewed changes
database/operations/kv.ts Outdated Show resolved Hide resolved
@roj1512
Copy link
Collaborator Author

roj1512 commented Sep 2, 2022

lemme see

@roj1512 @ArnabXD
Update database/operations/kv.ts
160a243 
Co-authored-by: Arnab Paryali <arnabparyali@gmail.com>
@roj1512 @ArnabXD
Update database/operations/kv.ts
892f854 
Co-authored-by: Arnab Paryali <arnabparyali@gmail.com>
@roj1512 @ArnabXD
Update database/operations/kv.ts
0354ba5 
Co-authored-by: Arnab Paryali <arnabparyali@gmail.com>
@ArnabXD
Copy link
Collaborator

ArnabXD commented Sep 2, 2022

lemme see

Or rather unknown can be a better option if we want to force to pass generic while using these.

@ArnabXD
fmt
3a97acc 
missing hooks
ArnabXD
ArnabXD approved these changes Sep 2, 2022
View reviewed changes
Copy link
Collaborator

@ArnabXD ArnabXD left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@roj1512 roj1512 merged commit b9bf356 into main Sep 2, 2022
@roj1512 roj1512 deleted the captcha branch September 2, 2022 18:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ArnabXD ArnabXD ArnabXD approved these changes

@dcdunkan dcdunkan Awaiting requested review from dcdunkan

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@roj1512 @ArnabXD @dcdunkan