Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(hooks): The hook package does not declare a utils dependency #461

Merged
merged 2 commits into from Apr 18, 2022

Conversation

zhoushaw
Copy link
Member

PR Details

The hook package does not declare a utils dependency

Description

  • The hook package does not declare a utils dependency
  • Prompt exception:Critical dependency: require function is used in a way in which dependencies cannot be statically extracted

image

Motivation and Context

How Has This Been Tested

  • No need to add tests

Types of changes

  • Docs change / refactoring / dependency upgrade
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@zhoushaw zhoushaw requested a review from danpeen April 18, 2022 02:30
@codecov
Copy link

codecov bot commented Apr 18, 2022

Codecov Report

Merging #461 (5150124) into main (ce539d8) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main     #461   +/-   ##
=======================================
  Coverage   78.95%   78.95%           
=======================================
  Files          86       86           
  Lines       10875    10875           
  Branches     1518     1518           
=======================================
  Hits         8586     8586           
  Misses       2281     2281           
  Partials        8        8           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f5267e8...5150124. Read the comment docs.

@zhoushaw zhoushaw merged commit 701457a into main Apr 18, 2022
@zhoushaw zhoushaw deleted the fix/hooks-critial-dpes branch April 18, 2022 03:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant