You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Also a quick note: when dispatching for SeqLike, I guess we can use SeqLikeType.__args__ as the type instead of hardcoding a list of potential types, otherwise it's hard to keep them consistent (since I saw there's a plan to include torch.tensor)
PR: #46
Note that the forward-ref should be removed or replaced (e.g. "torch.tensor" removed, "np.ndarray" replaced with the np.ndarray) to be compatible with dispatch. I also found the circular dependency of SeqLike and SeqLikeType a bit confusing. Let me know if I missed the context for this design or there's a better way.
Also a quick note: when dispatching for SeqLike, I guess we can use
SeqLikeType.__args__
as the type instead of hardcoding a list of potential types, otherwise it's hard to keep them consistent (since I saw there's a plan to include torch.tensor)Originally posted by @pagpires in #41 (comment)
The text was updated successfully, but these errors were encountered: