Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: Ability to hide/ disable the media control widget #43

Closed
Samuel12321 opened this issue Sep 18, 2020 · 15 comments
Closed

Feature: Ability to hide/ disable the media control widget #43

Samuel12321 opened this issue Sep 18, 2020 · 15 comments
Assignees
Labels
Enhancement New feature or request Fixed Has been fixed. UI/UX Related to appearance of the app and flyout.
Projects

Comments

@Samuel12321
Copy link
Member

The user may want the media widget not to be displayed so that the flyout is less intrusive and takes up less space. I think the ability to disable it would be nice.

@Samuel12321 Samuel12321 added the Enhancement New feature or request label Sep 18, 2020
@ShankarBUS
Copy link
Member

I was thinking of the same. We can implement a sub setting for this.

But even if they hide the media controls widget, the original one won't be shown. ModernFlyouts will just show the volume control. Is this a good behaviour?

@ShankarBUS ShankarBUS added the UI/UX Related to appearance of the app and flyout. label Sep 19, 2020
@Samuel12321
Copy link
Member Author

I think so, Could be re enabled if user wants it again.

@Poopooracoocoo
Copy link
Contributor

Poopooracoocoo commented Sep 20, 2020

I personally find it really annoying that the media controls show up when I change the volume and I'd be much happier if it were in the volume flyout (in the taskbar). Microsoft has finally done something about that but ironically hasn't changed anything else.

@ShankarBUS
Copy link
Member

I will provide an option to hide it in v0.6.

@Poopooracoocoo,

When is Microsoft planning to add the media controls to tray flyout?

Didn't know they were going to do this. Now I feel useless 😑😔

@Poopooracoocoo
Copy link
Contributor

I know that there's a feature flag in the insider 21H1 builds but I'm not sure when they'll actually release it.

It's not surprising that they only half did it and they'll probably release it with 22H1 in its current state, knowing MS :P

@Samuel12321 Samuel12321 added this to To do in v0.6 via automation Sep 21, 2020
@ShankarBUS ShankarBUS self-assigned this Sep 23, 2020
@ShankarBUS ShankarBUS moved this from To do to In progress in v0.6 Sep 24, 2020
@Samuel12321 Samuel12321 added this to the 0.6 milestone Sep 25, 2020
@ShankarBUS
Copy link
Member

Hey guys, this feature would require reorganizing settings into multiple pages and groups.

As a temporary fix, this option would be controllable by a toggle switch under the "Additional" group in the General page.

We need to reorganize settings so that each module get their own page (if they need multiple options e.g. Audio) or a fused page (e.g. Brightness and airplane)

We won't be able to do that until v0.8. So please bear with the current implementation 😅

@ShankarBUS
Copy link
Member

ShankarBUS commented Sep 28, 2020

Ummm, another problem.... When we disable the media transport controls in ModernFlyouts, the stock flyout pops-up while pressing the media keys

What would you want me to do?

Or how about this?

We should provide an option to show/hide media transport controls while pressing volume keys and another option to show/hide volume control while we press the media keys. So that the users will get to choose their preferred combo and also the stock flyout won't be shown in this case

@Samuel12321, @Cyberdroid1, @Poopooracoocoo
What are your thoughts guys?

@Samuel12321
Copy link
Member Author

sounds good to me

@ShankarBUS
Copy link
Member

We should provide an option to show/hide media transport controls while pressing volume keys and another option to show/hide volume control while we press the media keys.

In case you refer to this
We can only give an option to show/hide media transport controls while pressing volume keys currently. The other part could be done in v0.8

@Samuel12321
Copy link
Member Author

the option to show/hide media transport controls while pressing volume keys was actually the only thing i was thinking about when i opened this, the idea to be able to control both sounded like a nice option to have. The second part can wait till 0.8

@prakharb5
Copy link
Member

Sounds good to me too!

@ShankarBUS
Copy link
Member

Ok I will provide both options in v0.6 release. But we really need to do a lot of re-organization in the Settings Window and improve the usability of it

@Samuel12321
Copy link
Member Author

But we really need to do a lot of re-organization in the Settings Window and improve the usability of it

I think that needs to be the main focus of 0.8.

@ShankarBUS
Copy link
Member

ShankarBUS commented Sep 28, 2020

Yes that's what I said. Base impl in v0.6 and proper place with-in settings in v0.8

v0.6 automation moved this from In progress to Done Sep 28, 2020
v0.8.0 automation moved this from To do to Done Sep 28, 2020
@ShankarBUS
Copy link
Member

Fixed in cb23bc2

@prakharb5 prakharb5 added the Fixed Has been fixed. label Dec 28, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Enhancement New feature or request Fixed Has been fixed. UI/UX Related to appearance of the app and flyout.
Projects
No open projects
v0.6
  
Done
Development

No branches or pull requests

4 participants