Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move thumbnail to left of media flyout #49

Closed
Poopooracoocoo opened this issue Sep 21, 2020 · 12 comments
Closed

Move thumbnail to left of media flyout #49

Poopooracoocoo opened this issue Sep 21, 2020 · 12 comments
Assignees
Labels
Enhancement New feature or request Known issue Known Bug Low Priority UI/UX Related to appearance of the app and flyout.
Projects

Comments

@Poopooracoocoo
Copy link
Contributor

Poopooracoocoo commented Sep 21, 2020

This is a pre-emptive request, but I believe that Microsoft will move the cover/album art image/thumbnail to the left as Google has done this on Android and will soon do so on Chrome, and therefore Edge.

image

image

random rant that you shouldn't read

it's funny that chrome's global media controls (GMC) get updated more frequently than windows' system media transport controls (SMTC).
the GMC goes unchanged in edge too and yet only edge has a bug where the icon of a button doesn't change until you move your cursor away from it. lol.
still can't seek in the GMC or SMTC >:(
i really think google just saw ios and thought "ooh nice", especially with the "seamless media transfer"

@ShankarBUS
Copy link
Member

The original design had the thumbnail on the left 😂. Had to align the UI with Windows 10X so that people won't complain "wInDowS 10 is InCOnSisTEnt".

IMO, keeping the thumbnail on the right looks good UX wise. Because most of the people are used to LTR layouts. It is away from the text and looks noice.

I do agree keeping it on left is good. And if Google or Apple make a design doesn't mean Microsoft must copy it. Gotta do something different, different people prefer different things.

I will update the UI along with whatever design MS choose.

But that must not stop users from customising to their own taste.

So as for your case I can provide an option to align it to the "Left".

@Poopooracoocoo
Copy link
Contributor Author

And if Google or Apple make a design doesn't mean Microsoft must copy it

Microsoft doesn't have to but they probably will as they will probably want it to fit in with Edge. Edge could change the GMC but they haven't now, so why would they later? :p

The LTR argument could be made for the cover art being on the left. I don't mind whether the cover art is on the left or right tbh.

@ShankarBUS
Copy link
Member

If the thumbnail was on the left the layout will look crowded on the left. There will empty space on the right since not every media session is gonna have a long title. So I had to take the decision of keeping it on the right.

But I promise i will provide a way to customize it.

@ShankarBUS ShankarBUS added Enhancement New feature or request Known issue Known Bug Low Priority UI/UX Related to appearance of the app and flyout. labels Sep 22, 2020
@ShankarBUS ShankarBUS self-assigned this Sep 22, 2020
@Samuel12321 Samuel12321 added this to the 0.8 milestone Sep 25, 2020
@ShankarBUS
Copy link
Member

ShankarBUS commented Sep 28, 2020

@Poopooracoocoo,

still can't seek in the GMC or STMC >:(

We can actually seek the playback iff the source app supports seeking through SMTC. Currently we only have a ProgressBar to show the timeline properties. We could replace that with a slider to actually control the playback from our app. But the last time I tried, it was really slow. I will reconsider this in future versions

References :

Our side of control :

Media apps' side :

@ShankarBUS
Copy link
Member

@Poopooracoocoo, HmMmMMmMmmmMmMMm 🤔🤔🤔

image

What about this? U happy?

@Samuel12321
Copy link
Member

is this user changeable, i personally preferred it as it was. However it is good.

@Samuel12321
Copy link
Member

perhaps have the background image cover the width of the flyout (not stop a cm from the right side) and blur out like it does on the left side

@ShankarBUS
Copy link
Member

is this user changeable

Yup! Users can customize it.

i personally preferred it as it was

It will be aligned to right by default. I provided an option to switch it just because @Poopooracoocoo asked for it.

perhaps have the background image cover the width of the flyout (not stop a cm from the right side)

This is an issue with Spotify. It provides the thumbnail with pre-added padding and label. There's nothing we can do about it 🤷‍♂️

blur out like it does on the left side

Oh!!!!!!, I never thought of this. The fading should switch together with switch in thumbnail alignment.

@ShankarBUS
Copy link
Member

@Samuel12321, Is it okay now?

image

@ShankarBUS ShankarBUS moved this from In Progress to Done in v0.8.0 Oct 30, 2020
@Poopooracoocoo
Copy link
Contributor Author

Great work! Thank you so so very much for this and for ModernFlyouts! 😀

@Samuel12321
Copy link
Member

Looks Great

@ShankarBUS
Copy link
Member

@Poopooracoocoo,

Thanks for opening this feature request!

Your request has been implemented in 2dd9139.

Please give v0.8 a try once its available to you via MS Store or this repo.

Please give us more suggestions, feedbacks, ideas or bug reports in the future 😁.

My lazy ass brain couldn't come up with new ideas. So, I must admit that the community really guided me since v0.2 release (be bugs or new features).

I'm really happy to people that like and want this app to sustain and grow ❤.

@Poopooracoocoo Poopooracoocoo changed the title Move cover art to left of media flyout Move thumbnail to left of media flyout Nov 25, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Enhancement New feature or request Known issue Known Bug Low Priority UI/UX Related to appearance of the app and flyout.
Projects
No open projects
v0.8.0
  
Done
Development

No branches or pull requests

3 participants