fix(ts): fix element in query

phodal · Nov 15, 2022 · e87a90c · e87a90c
1 parent 04bf39b
commit e87a90c
Show file tree

Hide file tree

Showing 4 changed files with 30 additions and 3 deletions.
diff --git a/chapi-ast-typescript/src/main/antlr/TypeScriptParser.g4 b/chapi-ast-typescript/src/main/antlr/TypeScriptParser.g4
@@ -782,6 +782,8 @@ singleExpression
     | singleExpression '?'? '!'? '.' '#'? identifierName nestedTypeGeneric?  # MemberDotExpression
     // for: `onHotUpdateSuccess?.();`
     | singleExpression '?'? '!'? '.' '#'? '(' identifierName? ')'            # MemberDotExpression
+    // onChange?.(userName || password || null)
+    | singleExpression '?'? '!'? '.' '#'? '(' singleExpression? ')'          # MemberDotExpression
     // samples: `error?.response?.data?.message ?? error.message;`
     | singleExpression '??' singleExpression                                 # NullCoalesceExpression
     | singleExpression '!'                                                   # PropCheckExpression

diff --git a/chapi-ast-typescript/src/main/kotlin/chapi/ast/typescriptast/TypeScriptFullIdentListener.kt b/chapi-ast-typescript/src/main/kotlin/chapi/ast/typescriptast/TypeScriptFullIdentListener.kt
@@ -690,7 +690,7 @@ class TypeScriptFullIdentListener(node: TSIdentify) : TypeScriptAstListener() {
                     val memberDot = it as TypeScriptParser.MemberDotExpressionContext
                     when (val subName = memberDot.singleExpression()::class.java.simpleName) {
                         "ParenthesizedExpressionContext" -> {
-                            params += parseParenthesizedExpression(memberDot.singleExpression())
+                            params += parseParenthesizedExpression(memberDot.singleExpression().first())
                         }
                         "ArgumentsExpressionContext" -> {
                             // request.get('/api/v1/xxx?id=1').then(function(response){console.log(response)}).catch()

diff --git a/chapi-ast-typescript/src/test/kotlin/chapi/ast/typescriptast/TypeScriptAnalyserTest.kt b/chapi-ast-typescript/src/test/kotlin/chapi/ast/typescriptast/TypeScriptAnalyserTest.kt
@@ -3,8 +3,9 @@ package chapi.ast.typescriptast
 import chapi.domain.core.DataStructType
 import org.junit.jupiter.api.Assertions.assertEquals
 import org.junit.jupiter.api.Test
+import java.io.File
 
-internal class TypeScriptAnalyserTest {
+class TypeScriptAnalyserTest {
     @Test
     internal fun shouldAnalysisTypeScriptMultipleClass() {
         val content = this::class.java.getResource("/grammar/Class.ts")!!.readText()
@@ -66,4 +67,18 @@ internal class TypeScriptAnalyserTest {
         assertEquals(codeFile.PackageName, "@.grammar.AbstractClass")
         assertEquals(codeFile.DataStructures[0].Package, "@.grammar.AbstractClass")
     }
+
+    @Test
+    @Ignore
+    fun someBug() {
+        val dir = File("/Users/phodal/bug-ui-system")
+        dir.walkTopDown().forEach {
+            if (it.extension == "ts" || it.extension == "js") {
+                val content = it.readText()
+                println(it.absolutePath)
+                val codeFile = TypeScriptAnalyser().analysis(content, it.name)
+                println(codeFile)
+            }
+        }
+    }
 }
diff --git a/chapi-ast-typescript/src/test/kotlin/chapi/ast/typescriptast/TypeScriptBugTest.kt b/chapi-ast-typescript/src/test/kotlin/chapi/ast/typescriptast/TypeScriptBugTest.kt
@@ -20,11 +20,21 @@ exports.test = test;
     }
 
     @Test
-    fun backend_arrow_function2() {
+    fun of_keyword_lost() {
         val code = """
 import {EMPTY, Observable, of} from 'rxjs';
 """
 
         TypeScriptAnalyser().analysis(code, "index.tsx")
     }
+
+    @Test
+    fun member_dot_issue() {
+        val code = """export class DemoComponent implements OnInit, ControlValueAccessor {
+    ngOnInit(): void {
+        this.onChange?.(userName || password || null);
+    }
+}"""
+        TypeScriptAnalyser().analysis(code, "index.tsx")
+    }
 }